Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrollment app: handle past schedule messages #77

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Enrollment app: handle past schedule messages #77

merged 7 commits into from
Nov 10, 2023

Conversation

achen2401
Copy link

see Slack convo
part of https://www.pivotaltracker.com/story/show/183693507

Changes include:

  • add check to see if a scheduled message is in the past, if so:
    no CommunicationRequest resource will be created for it if it is a newly scheduled message
    if a CommunicationRequest has already been created, its status will be updated to revoked
  • add warning on UI to user if a scheduled message is in the past:
    Screen Shot 2023-11-07 at 11 52 44 AM

pbugni
pbugni approved these changes Nov 7, 2023
View reviewed changes
Copy link

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@achen2401 achen2401 merged commit 48c29e4 into dev Nov 10, 2023
1 check passed
@achen2401 achen2401 deleted the feature/enrollment-handle-past-messages branch November 10, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sierramatice sierramatice sierramatice approved these changes

@pbugni pbugni pbugni approved these changes

@mcjustin mcjustin Awaiting requested review from mcjustin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achen2401 @pbugni @sierramatice