Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a PlanDefinition for the COVE instance. #83

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Adds a PlanDefinition for the COVE instance. #83

merged 3 commits into from
Dec 29, 2023

Conversation

mcjustin
Copy link
Member

@mcjustin mcjustin commented Dec 13, 2023 •
edited
Loading

@mcjustin mcjustin requested a review from achen2401 December 13, 2023 18:14
@mcjustin mcjustin requested a review from ivan-c December 13, 2023 18:20
@mcjustin
Copy link
Member Author

@ivan-c though I have some questions for Amy here, I'd like to get this on a system for QA, and then for the research team to start playing with once it looks good (either stage or cove prod would work - they'd like to have this sometime next week)... I'm not finding any PlanDefinitions in Hapi for opc prod, so I think we just read these from the FS based on the isacc equivalent of a dhair2 instance_id?

@mcjustin
Copy link
Member Author

@ivan-c though I have some questions for Amy here, I'd like to get this on a system for QA, and then for the research team to start playing with once it looks good (either stage or cove prod would work - they'd like to have this sometime next week)... I'm not finding any PlanDefinitions in Hapi for opc prod, so I think we just read these from the FS based on the isacc equivalent of a dhair2 instance_id?

We decided to get this on dev and then eval (prod post-holidays)

@mcjustin
Copy link
Member Author

Noting that this looks good on the https://femr.isacc.eval.cirg.uw.edu system.

@mcjustin mcjustin requested a review from achen2401 December 28, 2023 20:59
@mcjustin mcjustin merged commit 35bab83 into dev Dec 29, 2023
1 check passed
@mcjustin mcjustin deleted the feature/cove-plandefinition branch December 29, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbugni pbugni pbugni left review comments

@achen2401 achen2401 achen2401 approved these changes

@ivan-c ivan-c Awaiting requested review from ivan-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcjustin @pbugni @achen2401