Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DEEP_FUTURE date to deep future date #77

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

achen2401
Copy link

@achen2401 achen2401 commented Jan 3, 2025

As reported by Anna, the Time Since Reply column is showing identical erroneous text due to default deep future date, i.e. 2025-01-01 is now in the past. (see code references here and here).

screenshots of issue:
Screenshot 2025-01-03 at 9 49 01 AM

Screenshot 2025-01-03 at 9 46 07 AM

Copy link
Member

@mcjustin mcjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amy, your change makes sense to me. Odd that we only had it at 2025 earlier... @pbugni do you recall why?

@pbugni
Copy link

pbugni commented Jan 7, 2025

Thanks Amy, your change makes sense to me. Odd that we only had it at 2025 earlier... @pbugni do you recall why?

I do not. Certainly wasn't very deep in the future...

@achen2401 achen2401 merged commit 9e7630f into develop Jan 7, 2025
2 checks passed
@achen2401 achen2401 deleted the bugfix/deep-future-date branch January 7, 2025 22:13
@mcjustin
Copy link
Member

@achen2401 , Anna asked today "for the bug with the "time since last reply" column, will we need to manually clear that date for each participant? If so, is there a way for your team to do so in a bulk action?"

Does this change need a corresponding migration?

@achen2401
Copy link
Author

@mcjustin sorry, I didn’t think this through, but I believe we do need a corresponding migration to address existing patient records with the not future date.

@mcjustin
Copy link
Member

mcjustin commented Jan 29, 2025

@mcjustin sorry, I didn’t think this through, but I believe we do need a corresponding migration to address existing patient records with the not future date.

@pbugni can you please take this migration on? It is a lower priority than the truenth issue.

(For my reference, we have used this capacity recently: #78 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants