Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust user's next-outgoing extension AFTER communication request status change #78

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

pbugni
Copy link

@pbugni pbugni commented Jan 7, 2025

Pivotal story: https://www.pivotaltracker.com/n/projects/2584667/stories/188742640

next-outgoing was incorrect after message send.
the code order was in error - the attempt to update the user's extension for "date-time-of-next-outgoing-message" happened prior to the communication request status change on message send.

This PR depends on uwcirg/isacc-environments#40 (or the migrations won't run correctly)

@pbugni pbugni requested review from mcjustin and achen2401 January 7, 2025 22:19
@achen2401
Copy link

@pbugni thank you. The fix appeared to resolve the issue that I saw.

first scheduled message date/time:
Screenshot 2025-01-07 at 2 48 58 PM

After that has been sent, the next scheduled message date/time displays as expected:
Screenshot 2025-01-07 at 2 56 33 PM
Screenshot 2025-01-07 at 2 55 50 PM

Copy link
Member

@mcjustin mcjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pretty naive approval from my end...

@pbugni pbugni requested a review from ivan-c January 8, 2025 04:01
@pbugni pbugni force-pushed the bugfix/correct-next-outgoing branch from bb72bbd to b46af32 Compare January 8, 2025 04:11
@pbugni pbugni merged commit dc2740b into develop Jan 15, 2025
2 checks passed
@pbugni pbugni deleted the bugfix/correct-next-outgoing branch January 15, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants