TN-3291 implement caching of research data, for performance improvement #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-05 20:45:35 UTC |
pbugni
commented
Jun 12, 2024
| @@ -370,7 +370,8 @@ def quote_double_quote(value): | |||
| answer['valueCoding'].get('text') | |||
| ) | |||
|
|
|||
| text_and_coded_answers.append({'valueString': text_answer}) | |||
| if text_answer is not None: | |||
There was a problem hiding this comment.
@ivan-c this change was necessary to get tests to pass, as some results after posting an update to a questionnaire response, would show valueString: None. i can't imagine it would ever be worth saving a valueString with a value of None in a questionnaire response, would it?
those were showing up as differences in the following test:
py.test tests/test_assessment_engine.py::TestAssessmentEngine::test_update_assessment
There was a problem hiding this comment.
i can't imagine it would ever be worth saving a
valueStringwith a value ofNonein a questionnaire response, would it?
probably not- None/null isn't the same type as valueString anyway
pbugni
force-pushed
the
feature/cache-reporting
branch
from
3c97fdf to
696a4df
Compare
pbugni
force-pushed
the
feature/cache-reporting
branch
2 times, most recently
from
a869bf0 to
c13ce5a
Compare
ivan-c
approved these changes
Jul 16, 2024
| @@ -370,7 +370,8 @@ def quote_double_quote(value): | |||
| answer['valueCoding'].get('text') | |||
| ) | |||
|
|
|||
| text_and_coded_answers.append({'valueString': text_answer}) | |||
| if text_answer is not None: | |||
There was a problem hiding this comment.
i can't imagine it would ever be worth saving a
valueStringwith a value ofNonein a questionnaire response, would it?
probably not- None/null isn't the same type as valueString anyway
pbugni
force-pushed
the
feature/cache-reporting
branch
from
d8d0c47 to
1641407
Compare
…ionnaire-response: questionnaire-bank association.
…n the research_data table.
…long to a single patient, no need for a unique(patient, qnr_id)
…caches, refactor `invalidate_existing` out of `update_users_QBT()` for consistent use.
…rom research_data.
pbugni
force-pushed
the
feature/cache-reporting
branch
from
2df1268 to
b2c9a92
Compare
ivan-c
pushed a commit
that referenced
this pull request
Sep 10, 2024
…nt (#4382) Reports from the field - the generation of research_data has become unreliable due to time it takes to build report. Now retaining a table of cached values, one row per questionnaire response, for a responsive report generation. Primary concern will be with cache-invalidation, especially on an org change of research protocol or a user's consent date change. There is now a scheduled job that runs daily, to seek out any overlooked QNRs missing from this new cache table `research_data`. A dry run of the prod db: ``` "found 92748 questionnaire responses missing from research_data cache" [...] ""Task portal.tasks.cache_research_data_task[f87d7130-d2b2-4413-a461-61cf3ebc9594] succeeded in 32897.385058208994s" ``` thereafter, it will generally find zero, as we immediately update on QNR put/post.
ivan-c
pushed a commit
that referenced
this pull request
Sep 10, 2024
…nt (#4382) Reports from the field - the generation of research_data has become unreliable due to time it takes to build report. Now retaining a table of cached values, one row per questionnaire response, for a responsive report generation. Primary concern will be with cache-invalidation, especially on an org change of research protocol or a user's consent date change. There is now a scheduled job that runs daily, to seek out any overlooked QNRs missing from this new cache table `research_data`. A dry run of the prod db: ``` "found 92748 questionnaire responses missing from research_data cache" [...] ""Task portal.tasks.cache_research_data_task[f87d7130-d2b2-4413-a461-61cf3ebc9594] succeeded in 32897.385058208994s" ``` thereafter, it will generally find zero, as we immediately update on QNR put/post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports from the field - the generation of research_data has become unreliable due to time it takes to build report.
Now retaining a table of cached values, one row per questionnaire response, for a responsive report generation.
Primary concern will be with cache-invalidation, especially on an org change of research protocol or a user's consent date change.
There is now a scheduled job that runs daily, to seek out any overlooked QNRs missing from this new cache table
research_data. A dry run of the prod db:thereafter, it will generally find zero, as we immediately update on QNR put/post.