Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update uuid dependency to version 4.1.0 #375

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Update uuid dependency to version 4.1.0 #375

merged 4 commits into from
Nov 17, 2023

Conversation

vlazdra
Copy link
Contributor

@vlazdra vlazdra commented Nov 17, 2023

Resolves #364

@Zazo032 Zazo032 added the platform-dart Specific to Dart code label Nov 17, 2023
@Zazo032
Copy link
Collaborator

Zazo032 commented Nov 17, 2023

Thanks for the quick fix! Can you also bump the version in pubspec.yaml and add a new entry to the CHANGELOG.md?

@vlazdra
Copy link
Contributor Author

vlazdra commented Nov 17, 2023

Hey @Zazo032 👋
I've updated the version in pubspec.yaml and the CHANGELOG.md.

But not sure if it's possible to update the intercom_flutter package dependency for the library until it's published to pub.dev?
This can be updated latter on if you want once this is published: https://github.com/v3rm0n/intercom_flutter/blob/master/intercom_flutter/pubspec.yaml#L13

@Zazo032 Zazo032 self-requested a review November 17, 2023 14:11
@Zazo032
Copy link
Collaborator

Zazo032 commented Nov 17, 2023

Thanks! We can merge and publish the web package first, then update it in the main one

@zigapovhe zigapovhe mentioned this pull request Nov 17, 2023
Closed
@Zazo032 Zazo032 merged commit 03921c0 into v3rm0n:master Nov 17, 2023
2 of 3 checks passed
@vlazdra vlazdra mentioned this pull request Nov 20, 2023
Closed
junaid1460
junaid1460 reviewed Feb 1, 2024
View reviewed changes
intercom_flutter_web/pubspec.yaml
@@ -16,7 +16,7 @@ dependencies:
flutter_web_plugins:
sdk: flutter
intercom_flutter_platform_interface: ^2.0.0
uuid: ^3.0.7 # to get the random uuid for loginUnidentifiedUser in web
uuid: ^4.2.1 # to get the random uuid for loginUnidentifiedUser in web
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be an exact match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaid1460 junaid1460 junaid1460 left review comments

@Zazo032 Zazo032 Zazo032 approved these changes

Assignees

@vlazdra vlazdra

Labels
platform-dart Specific to Dart code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with UUID v4
3 participants
@vlazdra @Zazo032 @junaid1460