Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayMessageComposer future never completes on iOS #404

Merged
merged 2 commits into from
Feb 13, 2024
Merged

displayMessageComposer future never completes on iOS #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fd900
Fix
Alex-Usmanov Feb 13, 2024
3c3ac92
Bump version and add changelog
Alex-Usmanov Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions intercom_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 8.0.12

* Fix never completing future when calling displayMessageComposer on iOS

## 8.0.11

* Automatically Injected Intercom Script, if it is not added.
Expand Down
1 change: 1 addition & 0 deletions intercom_flutter/ios/Classes/IntercomFlutterPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ - (void) handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
else if([@"displayMessageComposer" isEqualToString:call.method]) {
NSString *message = call.arguments[@"message"];
[Intercom presentMessageComposer:message];
result(@"Presented message composer");
} else if([@"sendTokenToIntercom" isEqualToString:call.method]){
NSString *token = call.arguments[@"token"];
if(token != (id)[NSNull null] && token != nil) {
Expand Down
2 changes: 1 addition & 1 deletion intercom_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: intercom_flutter
description: Flutter plugin for Intercom integration. Provides in-app messaging
and help-center Intercom services
version: 8.0.11
version: 8.0.12
homepage: https://github.com/v3rm0n/intercom_flutter

dependencies:
Expand Down
Loading