Add latency sample for transaction and pipeline #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ray Cao <zisong.cw@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1424 +/- ##
============================================
+ Coverage 70.71% 70.87% +0.15%
============================================
Files 119 119
Lines 64652 64628 -24
============================================
+ Hits 45717 45802 +85
+ Misses 18935 18826 -109
|
xbasel
reviewed
Dec 16, 2024
| @@ -3112,6 +3112,10 @@ int canParseCommand(client *c) { | |||
| } | |||
|
|
|||
| int processInputBuffer(client *c) { | |||
| mstime_t latency; | |||
| latencyStartMonitor(latency); | |||
There was a problem hiding this comment.
Has the impact of gettimeofday been measured? it will be executed on every single command.
There was a problem hiding this comment.
I believe gettimeofday is a very lightweight operation because of vDSO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users put too many commands in a transaction or pipeline, the execution time might exceed the
latency_monitor_thresholdvalue.So, Maybe it's necessary to record latency for pipeline and transaction, which can help them to find out potential misuse of transaction or pipeline.