Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): add notification approval before starting a new game #332

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

vareversat
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 4.42% and project coverage change: -2.10 ⚠️

Comparison is base (b513403) 41.70% compared to head (b60cf6f) 39.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #332      +/-   ##
==========================================
- Coverage   41.70%   39.61%   -2.10%     
==========================================
  Files         181      193      +12     
  Lines        6426     6773     +347     
==========================================
+ Hits         2680     2683       +3     
- Misses       3746     4090     +344     
Impacted Files Coverage Δ
lib/helpers/correct_instance.dart 0.00% <0.00%> (ø)
...odels/notification/abstract_game_notification.dart 0.00% <0.00%> (ø)
lib/models/notification/abstract_notification.dart 0.00% <0.00%> (ø)
...b/models/notification/game_ended_notification.dart 0.00% <0.00%> (ø)
lib/models/notification/new_game_notification.dart 0.00% <0.00%> (ø)
lib/models/notification/system_notification.dart 0.00% <0.00%> (ø)
lib/repositories/impl/notification_repository.dart 0.00% <0.00%> (ø)
...notification/abstract_notification_repository.dart 0.00% <0.00%> (ø)
lib/services/game/abstract_game_service.dart 44.00% <ø> (ø)
lib/services/impl/notification_service.dart 0.00% <0.00%> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant