Skip to content

Commit

Permalink
fix not found error
Browse files Browse the repository at this point in the history
  • Loading branch information
datelier committed Oct 30, 2024
1 parent 91518e5 commit c42ceaa
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions pkg/gateway/lb/handler/grpc/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -1904,13 +1904,12 @@ func (s *server) MultiUpdate(
}

if errs != nil {
st, _ := status.FromError(err)
st, _ := status.FromError(errs)

Check warning on line 1907 in pkg/gateway/lb/handler/grpc/handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/gateway/lb/handler/grpc/handler.go#L1907

Added line #L1907 was not covered by tests
if st != nil && span != nil {
span.RecordError(err)
span.RecordError(errs)

Check warning on line 1909 in pkg/gateway/lb/handler/grpc/handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/gateway/lb/handler/grpc/handler.go#L1909

Added line #L1909 was not covered by tests
span.SetAttributes(trace.FromGRPCStatus(st.Code(), st.Message())...)
span.SetStatus(trace.StatusError, err.Error())
span.SetStatus(trace.StatusError, errs.Error())

Check warning on line 1911 in pkg/gateway/lb/handler/grpc/handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/gateway/lb/handler/grpc/handler.go#L1911

Added line #L1911 was not covered by tests
}
errs = err
}

return locs, errs
Expand Down Expand Up @@ -2735,13 +2734,12 @@ func (s *server) MultiRemove(
}

if errs != nil {
st, _ := status.FromError(err)
st, _ := status.FromError(errs)

Check warning on line 2737 in pkg/gateway/lb/handler/grpc/handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/gateway/lb/handler/grpc/handler.go#L2737

Added line #L2737 was not covered by tests
if st != nil && span != nil {
span.RecordError(err)
span.RecordError(errs)

Check warning on line 2739 in pkg/gateway/lb/handler/grpc/handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/gateway/lb/handler/grpc/handler.go#L2739

Added line #L2739 was not covered by tests
span.SetAttributes(trace.FromGRPCStatus(st.Code(), st.Message())...)
span.SetStatus(trace.StatusError, err.Error())
span.SetStatus(trace.StatusError, errs.Error())

Check warning on line 2741 in pkg/gateway/lb/handler/grpc/handler.go

View check run for this annotation

Codecov / codecov/patch

pkg/gateway/lb/handler/grpc/handler.go#L2741

Added line #L2741 was not covered by tests
}
errs = err
}

return locs, errs
Expand Down

0 comments on commit c42ceaa

Please sign in to comment.