-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #2620 to release/v1.7 for [Bugfix] agent service test #2622
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -13,8 +13,14 @@ | |||||||||||||||
# See the License for the specific language governing permissions and | ||||||||||||||||
# limitations under the License. | ||||||||||||||||
# | ||||||||||||||||
|
||||||||||||||||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||||||||||||||||
<<<<<<< HEAD | ||||||||||||||||
name: 'Build docker image: agent' | ||||||||||||||||
======= | ||||||||||||||||
|
||||||||||||||||
name: "Build docker image: agent" | ||||||||||||||||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||||||||||||||||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. The file has unresolved merge conflict markers. The desired version of the To resolve the conflict, apply this diff: -<<<<<<< HEAD
-name: 'Build docker image: agent'
-=======
-
name: "Build docker image: agent"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) Committable suggestion
Suggested change
Toolsactionlint
|
||||||||||||||||
on: | ||||||||||||||||
push: | ||||||||||||||||
branches: | ||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: agent-ngt' | ||
======= | ||
Comment on lines
+18
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the YAML parsing error. The static analysis tool actionlint has flagged a valid YAML parsing error at line 19:
This error is caused by the Git conflict markers ( To fix this error, please resolve the Git conflict by removing the conflict markers and keeping only the desired version of the code. For example: -<<<<<<< HEAD
-name: 'Build docker image: agent-ngt'
-=======
-
name: "Build docker image: agent-ngt"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) Do you want me to open a GitHub issue to track this task?
Toolsactionlint
|
||
|
||
name: "Build docker image: agent-ngt" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: agent-sidecar' | ||
======= | ||
|
||
name: "Build docker image: agent-sidecar" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. There is an unresolved merge conflict in the workflow file, as indicated by the presence of Git conflict markers Please resolve the merge conflict by deciding which version of the Toolsactionlint
|
||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -13,8 +13,14 @@ | |||||||||||||||
# See the License for the specific language governing permissions and | ||||||||||||||||
# limitations under the License. | ||||||||||||||||
# | ||||||||||||||||
|
||||||||||||||||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||||||||||||||||
<<<<<<< HEAD | ||||||||||||||||
name: 'Build docker image: benchmark-job' | ||||||||||||||||
======= | ||||||||||||||||
|
||||||||||||||||
name: "Build docker image: benchmark-job" | ||||||||||||||||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||||||||||||||||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the YAML parsing error. There is a YAML parsing error due to the Git conflict markers To resolve this, remove the Git conflict markers and keep only the desired version of the workflow name: -<<<<<<< HEAD
-name: 'Build docker image: benchmark-job'
-=======
-
-name: "Build docker image: benchmark-job"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620))
+name: "Build docker image: benchmark-job" Committable suggestion
Suggested change
Toolsactionlint
|
||||||||||||||||
on: | ||||||||||||||||
push: | ||||||||||||||||
branches: | ||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: benchmark-operator' | ||
======= | ||
|
||
name: "Build docker image: benchmark-operator" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. There are conflict markers ( Please resolve the merge conflict by removing the conflict markers and keeping the desired version of the workflow name. Toolsactionlint
|
||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: buildkit' | ||
======= | ||
|
||
name: "Build docker image: buildkit" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. There are Git conflict markers present in the workflow file, causing a YAML parsing error. Please resolve the merge conflict by either accepting the current change, the incoming change, or manually merging the changes. Toolsactionlint
|
||
on: | ||
schedule: | ||
- cron: 0 * * * * | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: buildkit-syft-scanner' | ||
======= | ||
|
||
name: "Build docker image: buildkit-syft-scanner" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. There are merge conflict markers ( Toolsactionlint
|
||
on: | ||
schedule: | ||
- cron: 0 * * * * | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: dev-container' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. There is an unresolved merge conflict in this file at line 19. The Please resolve the conflict by deciding which version of the workflow name to keep - either single quotes or double quotes. Remove the conflict markers Toolsactionlint
|
||
======= | ||
|
||
name: "Build docker image: dev-container" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: discoverer-k8s' | ||
======= | ||
|
||
name: "Build docker image: discoverer-k8s" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve Git conflict markers. The file contains Git conflict markers that are causing YAML parsing errors. This needs to be resolved before merging the changes. To resolve the conflict markers, remove the following lines: -<<<<<<< HEAD
-name: 'Build docker image: discoverer-k8s'
-=======
-
-name: "Build docker image: discoverer-k8s"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) And keep only the desired version of the workflow name: name: "Build docker image: discoverer-k8s" Toolsactionlint
|
||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -13,8 +13,14 @@ | |||||||||||||||||||||
# See the License for the specific language governing permissions and | ||||||||||||||||||||||
# limitations under the License. | ||||||||||||||||||||||
# | ||||||||||||||||||||||
|
||||||||||||||||||||||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||||||||||||||||||||||
<<<<<<< HEAD | ||||||||||||||||||||||
name: 'Build docker image: gateway-lb' | ||||||||||||||||||||||
======= | ||||||||||||||||||||||
|
||||||||||||||||||||||
name: "Build docker image: gateway-lb" | ||||||||||||||||||||||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||||||||||||||||||||||
Comment on lines
+16
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the YAML parsing error caused by the new line. The new line added at line 16 is causing a YAML parsing error because it breaks the structure of the YAML document. The error message from actionlint confirms this:
To fix the YAML parsing error, remove the new line at line 16: -
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go
-<<<<<<< HEAD
-name: 'Build docker image: gateway-lb'
-=======
-
name: "Build docker image: gateway-lb"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) Committable suggestion
Suggested change
Toolsactionlint
|
||||||||||||||||||||||
on: | ||||||||||||||||||||||
push: | ||||||||||||||||||||||
branches: | ||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: helm-operator' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the YAML parsing error. The static analysis tool Resolve the merge conflict by removing the conflict markers, which will also fix the YAML parsing error. Toolsactionlint
|
||
======= | ||
|
||
name: "Build docker image: helm-operator" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict. There are merge conflict markers present in the file, which need to be resolved before merging the changes. The conflict is related to the formatting of the name field. To resolve the conflict, remove the conflict markers and keep either the single quotes or double quotes version of the name field, based on the project's coding style guidelines. Toolsactionlint
|
||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: index-correction' | ||
======= | ||
|
||
name: "Build docker image: index-correction" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve merge conflict. There are unresolved merge conflict markers in the file. The conflict seems to be around the Based on the context, the preferred change appears to be: name: "Build docker image: index-correction" Please resolve the conflict by removing the conflict markers and keeping the above line. Toolsactionlint
|
||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: index-creation' | ||
======= | ||
|
||
name: "Build docker image: index-creation" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolve the merge conflict and fix the YAML parsing error. There are merge conflict markers present in the file, which is causing a YAML parsing error at line 19 as indicated by the static analysis tool. Please resolve the merge conflict and ensure the file is properly formatted. Toolsactionlint
|
||
on: | ||
push: | ||
branches: | ||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -13,8 +13,14 @@ | |||||||||||||||
# See the License for the specific language governing permissions and | ||||||||||||||||
# limitations under the License. | ||||||||||||||||
# | ||||||||||||||||
|
||||||||||||||||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||||||||||||||||
<<<<<<< HEAD | ||||||||||||||||
name: 'Build docker image: index-operator' | ||||||||||||||||
======= | ||||||||||||||||
|
||||||||||||||||
name: "Build docker image: index-operator" | ||||||||||||||||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||||||||||||||||
Comment on lines
+18
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the merge conflict resolution. The merge conflict resolution on lines 18-23 is incorrect and introduces a YAML syntax error. The conflict markers Apply this diff to fix the merge conflict resolution: -<<<<<<< HEAD
-name: 'Build docker image: index-operator'
-=======
-
name: "Build docker image: index-operator"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) Committable suggestion
Suggested change
Toolsactionlint
|
||||||||||||||||
on: | ||||||||||||||||
push: | ||||||||||||||||
branches: | ||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,14 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
# DO_NOT_EDIT this workflow file is generated by https://github.com/vdaas/vald/blob/main/hack/actions/gen/main.go | ||
<<<<<<< HEAD | ||
name: 'Build docker image: index-save' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix the YAML syntax error. The static analysis tool Please remove the lines with the merge conflict markers to fix the YAML syntax: -<<<<<<< HEAD
-name: 'Build docker image: index-save'
-=======
-
name: "Build docker image: index-save"
->>>>>>> 5ba13751f ([Bugfix] agent service test (#2620))
Toolsactionlint
|
||
======= | ||
|
||
name: "Build docker image: index-save" | ||
>>>>>>> 5ba13751f ([Bugfix] agent service test (#2620)) | ||
on: | ||
push: | ||
branches: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the YAML parsing error.
The actionlint static analysis tool has flagged a YAML parsing error at line 19 due to the unresolved merge conflict markers.
This error will be automatically fixed once the merge conflict is resolved by removing the conflict markers as suggested in the previous comment.
Tools
actionlint