Recreate PR #2600 and refresh branch #2801
Conversation
|
|
|
Warning Rate limit exceeded@kmrmt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 13 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request introduces significant enhancements to the metadata service within the Rust binary, focusing on key-value store management, observability, and tracing. Changes include the addition of new dependencies, the implementation of a Changes
Possibly related PRs
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying vald with
|
| Latest commit: |
f717624
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9ebb4d95.vald.pages.dev |
| Branch Preview URL: | https://feature-meta-rebase-main.vald.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (8)
rust/bin/meta/src/main.rs (2)
28-44: ImplementCloneforMetadataMapfor Potential Future UseWhile the current implementation of
MetadataMapworks, consider implementingCloneorCopytraits forMetadataMapto enhance its usability, especially if you plan to pass instances across threads or tasks in the future.
46-51: Handle Possible Errors in the Interceptor FunctionThe
interceptfunction currently does not handle any potential errors that might occur during the extraction of the parent context. Although unlikely, it's good practice to handle or log unexpected situations to aid in debugging.Consider adding error handling or logging within the
interceptfunction:fn intercept(mut req: Request<()>) -> Result<Request<()>, tonic::Status> { let parent_cx = - global::get_text_map_propagator(|prop| prop.extract(&MetadataMap(req.metadata()))); + global::get_text_map_propagator(|prop| prop.extract(&MetadataMap(req.metadata()))).clone(); req.extensions_mut().insert(parent_cx); Ok(req) }rust/bin/meta/src/handler/meta.rs (2)
65-91: Simplify NestedmatchStatements and Improve Error MessagesThe
setmethod has deeply nestedmatchstatements, which can be simplified for better readability. Additionally, the error messages could be more consistent.Refactor the code to flatten the
matchstatements:let key_value = request.into_inner(); -let key = match key_value.key { - Some(k) => k.key, - None => { - ctx.span().add_event("Invalid argument", vec![KeyValue::new("error", "Key is missing")]); - return Err(tonic::Status::invalid_argument("Key is missing")); - } -}; -let value = match key_value.value { - Some(v) => match v.value { - Some(any_value) => any_value.value, - None => { - ctx.span().add_event("Invalid argument", vec![KeyValue::new("error", "Value is missing")]); - return Err(tonic::Status::invalid_argument("Value is missing")); - } - }, - None => { - ctx.span().add_event("Invalid argument", vec![KeyValue::new("error", "Value is missing")]); - return Err(tonic::Status::invalid_argument("Value is missing")); - } -}; +if key_value.key.is_none() || key_value.value.is_none() { + ctx.span().add_event("Invalid argument", vec![KeyValue::new("error", "Key or Value is missing")]); + return Err(tonic::Status::invalid_argument("Key or Value is missing")); +} + +let key = key_value.key.unwrap().key; +let value = if let Some(any_value) = key_value.value.unwrap().value { + any_value.value +} else { + ctx.span().add_event("Invalid argument", vec![KeyValue::new("error", "Value is missing")]); + return Err(tonic::Status::invalid_argument("Value is missing")); +};
119-128: Handle Deletion of Non-Existent Keys GracefullyWhen deleting a key that does not exist, the method may return an error or succeed silently. Consider defining the expected behavior and handling it accordingly.
Perhaps inform the client if the key did not exist:
match self.bucket.remove(&raw_key) { Ok(Some(_)) => { ctx.span().add_event("Key deleted successfully", vec![KeyValue::new("key", key)]); Ok(tonic::Response::new(Empty {})) }, + Ok(None) => { + ctx.span().add_event("Key not found", vec![KeyValue::new("key", key)]); + Err(tonic::Status::not_found("Key not found")) + }, Err(e) => { ctx.span().add_event("Failed to delete key", vec![KeyValue::new("error", e.to_string())]); Err(tonic::Status::internal(format!("Failed to delete key: {}", e))) } }rust/bin/meta/src/handler.rs (1)
29-30: Close the Store Properly on ShutdownEnsure that the
Storeis properly closed when the application shuts down to prevent data corruption.Implement the
Droptrait or provide a shutdown method forMeta:impl Drop for Meta { fn drop(&mut self) { // Close the store if let Err(e) = self.store.close() { eprintln!("Failed to close store: {}", e); } } }rust/bin/meta/src/test_client.rs (2)
48-48: Consider configurable endpoint.The endpoint is hardcoded to "http://[::1]:8081". Consider making it configurable through environment variables or command-line arguments.
+use std::env; + #[tokio::main] async fn main() -> Result<(), Box<dyn std::error::Error>> { - let mut client = MetaClient::connect("http://[::1]:8081").await?; + let endpoint = env::var("META_SERVICE_ENDPOINT") + .unwrap_or_else(|_| "http://[::1]:8081".to_string()); + let mut client = MetaClient::connect(endpoint).await?;
130-134: Improve error handling in get operation.The error handling for the get operation after deletion only prints the error. Consider implementing proper error handling or recovery logic.
- match response { - Ok(res) => println!("Get key: aaa, RESPONSE={:?}", res.into_inner()), - Err(e) => println!("Get key: aaa failed with error: {:?}", e), - } + match response { + Ok(res) => println!("Get key: aaa, RESPONSE={:?}", res.into_inner()), + Err(e) => { + if e.code() == tonic::Code::NotFound { + println!("Key 'aaa' was successfully deleted and is not found"); + } else { + eprintln!("Unexpected error while getting key 'aaa': {:?}", e); + } + } + }rust/bin/meta/Cargo.toml (1)
32-35: Consider adding integration tests for the test client.While the test client is marked as
doc = false, it would be beneficial to have integration tests to ensure it works correctly with the metadata service.Consider adding a
testsdirectory with integration tests for the test client functionality.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
rust/bin/meta/Cargo.toml(1 hunks)rust/bin/meta/src/handler.rs(1 hunks)rust/bin/meta/src/handler/meta.rs(1 hunks)rust/bin/meta/src/main.rs(1 hunks)rust/bin/meta/src/test_client.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: check-format-diff
- GitHub Check: runner / textlint
- GitHub Check: Cloudflare Pages
- GitHub Check: Analyze (go)
🔇 Additional comments (5)
rust/bin/meta/src/main.rs (1)
96-96: Ensure Proper Shutdown of Observability SystemThe
observability.shutdown()?call might return an error that is currently being ignored. To ensure proper resource cleanup, handle any potential errors during shutdown.Check if the shutdown method can fail and handle the error accordingly:
observability.shutdown()?; +println!("Observability system shut down successfully.");Or handle the error:
-if let Err(e) = observability.shutdown() { - eprintln!("Failed to shut down observability system: {}", e); -}rust/bin/meta/src/handler/meta.rs (1)
79-91: ValidateAnyMessage TypesWhen handling
prost_types::Any, it's important to validate thetype_urlto ensure that the received message is of the expected type.Add validation for the
type_url:if any_value.type_url != "type.googleapis.com/expected.MessageType" { ctx.span().add_event("Invalid message type", vec![KeyValue::new("type_url", any_value.type_url)]); return Err(tonic::Status::invalid_argument("Invalid message type")); }rust/bin/meta/src/handler.rs (2)
28-32: Ensure Thread Safety and Consider Using a Singleton for the StoreThe
storeis wrapped in anArc, which is good for sharing across threads. Ensure that theStoreandBuckettypes are thread-safe if they will be accessed concurrently.Check the documentation for the
kvcrate to confirm thatStoreandBucketare safe to share between threads. If they are not, consider using synchronization primitives or limiting access to a single thread.
30-30:⚠️ Potential issueHandle Possible Errors When Creating the Bucket
When creating the bucket with
store.bucket, consider handling the possibility that the bucket already exists or cannot be created.Add error handling or check for existing buckets:
let bucket = store.bucket::<Raw, Raw>(Some("meta_bucket"))?; +// Alternatively, check if the bucket exists and handle accordinglyLikely invalid or redundant comment.
rust/bin/meta/Cargo.toml (1)
22-24: Verify dependency versions for security and compatibility.Several new dependencies have been added. Please verify:
- Check for any known vulnerabilities in these versions
- Ensure compatibility with the rest of the ecosystem
Also applies to: 26-26
✅ Verification successful
Dependencies are consistently versioned across the codebase
The new dependencies are properly aligned:
prost-types 0.13.2is consistently used across all Rust componentskv 0.24.0andopentelemetry 0.23.0are cleanly introduced only in the meta componentNote: The API documentation mentions an older version of
prost-typesand might need updating, but this is not a blocking issue.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for known vulnerabilities in dependencies cargo audit # List all dependency versions for verification cargo treeLength of output: 218
Script:
#!/bin/bash # Find all Cargo.toml files echo "=== Cargo.toml files ===" fd Cargo.toml # Search for kv dependency versions echo -e "\n=== kv dependency versions ===" rg "kv\s*=\s*\"[^\"]*\"" -A 1 -B 1 # Search for opentelemetry versions echo -e "\n=== opentelemetry versions ===" rg "opentelemetry\s*=\s*\"[^\"]*\"" -A 1 -B 1 # Search for prost-types versions echo -e "\n=== prost-types versions ===" rg "prost-types\s*=\s*\"[^\"]*\"" -A 1 -B 1Length of output: 1594
kmrmt
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
rust/bin/meta/src/main.rs (1)
74-82: 🛠️ Refactor suggestionExternalize observability configuration.
The observability configuration is hardcoded. Consider moving it to a configuration file or environment variables.
rust/bin/meta/src/handler/meta.rs (2)
40-43:⚠️ Potential issueFix the type_url in Any message.
The type_url contains a placeholder value which should be replaced with the actual protobuf type.
- type_url: "type.googleapis.com/your.package.MessageType".to_string(), + type_url: "type.googleapis.com/vald.v1.payload.meta.Value".to_string(),
33-58: 🛠️ Refactor suggestionConsider using async database operations.
The synchronous database operations could block the async runtime. Consider using async operations or moving them to a separate thread pool.
🧹 Nitpick comments (3)
rust/libs/observability/src/observability.rs (1)
71-80: Consider adding adaptive sampling.The current implementation uses
AlwaysOnsampling, which might generate excessive telemetry data in production. Consider implementing adaptive sampling based on traffic patterns.- .with_sampler(trace::Sampler::AlwaysOn) + .with_sampler(trace::Sampler::ParentBased(Box::new( + trace::Sampler::TraceIdRatioBased(0.1) + )))rust/bin/meta/Cargo.toml (1)
22-26: Consider consolidating key-value store dependencies.Both
kvandsledare being used as key-value stores. Consider using just one of them to reduce dependency overhead and potential complexity.rust/bin/meta/src/handler/meta.rs (1)
96-105: Add transaction support for database operations.The set operation could fail after partial completion. Consider wrapping it in a transaction for atomicity.
- match self.bucket.set(&raw_key, &raw_value) { + match self.bucket.transaction(|tx| { + tx.set(&raw_key, &raw_value)?; + Ok(()) + }) {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
rust/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (15)
rust/bin/agent/Cargo.toml(1 hunks)rust/bin/meta/Cargo.toml(1 hunks)rust/bin/meta/src/handler/meta.rs(1 hunks)rust/bin/meta/src/main.rs(1 hunks)rust/bin/meta/src/test_client.rs(1 hunks)rust/libs/algorithm/Cargo.toml(1 hunks)rust/libs/algorithms/ngt/Cargo.toml(1 hunks)rust/libs/algorithms/qbg/Cargo.toml(1 hunks)rust/libs/observability/Cargo.toml(1 hunks)rust/libs/observability/src/lib.rs(1 hunks)rust/libs/observability/src/macros.rs(2 hunks)rust/libs/observability/src/observability.rs(2 hunks)rust/libs/proto/Cargo.toml(1 hunks)rust/rust-toolchain(1 hunks)versions/RUST_VERSION(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- versions/RUST_VERSION
- rust/libs/observability/src/lib.rs
- rust/rust-toolchain
- rust/libs/algorithm/Cargo.toml
- rust/libs/algorithms/qbg/Cargo.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- rust/bin/meta/src/test_client.rs
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: check-format-diff
- GitHub Check: build / build
- GitHub Check: Analyze (go)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (11)
rust/libs/observability/src/observability.rs (2)
16-16: LGTM! Import changes look good.The imports have been simplified and properly organized to include the necessary OpenTelemetry components.
Also applies to: 18-19
54-65: Verify the endpoint URL construction.The URL construction for metrics endpoint could fail if:
- The base endpoint URL is invalid
- The "/v1/metrics" path join fails
Run this script to validate the endpoint URL construction:
Additionally, consider adding error recovery or fallback mechanisms for URL parsing failures.
✅ Verification successful
URL construction is properly implemented and safe ✅
The endpoint URL construction follows Rust best practices:
- Uses standard library's URL parsing and validation
- Properly propagates errors using the
?operator- Safely handles path joining
The suggestion for additional error recovery isn't necessary as the current implementation appropriately fails fast on invalid configurations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the metrics endpoint URL is properly constructed # Test: Extract and validate the endpoint URL format from the code rg -A 2 'with_endpoint.*metrics' | grep -E 'Url::parse.*join.*metrics'Length of output: 221
Script:
#!/bin/bash # Check for error handling patterns and tests related to URL configuration rg -g '*.rs' -B 2 -A 2 'endpoint.*Error|Error.*endpoint'Length of output: 58
rust/libs/observability/src/macros.rs (1)
68-73: LGTM! Macro changes improve hygiene and follow OpenTelemetry's latest API.The changes consistently:
- Use
$crate::pastefor proper macro hygiene- Replace
.init()with.build()to align with OpenTelemetry's builder patternAlso applies to: 79-87, 93-98, 104-112, 118-123, 129-134, 140-148
rust/libs/algorithms/ngt/Cargo.toml (1)
22-23: Verify compatibility with updated dependencies.The dependency updates include significant version bumps. Please verify:
- Breaking changes in cxx/cxx-build 1.0.136
- Compatibility with the C++20 feature flag
Also applies to: 26-27
✅ Verification successful
Dependencies update is safe to proceed
The cxx/cxx-build 1.0.136 update is compatible with the existing C++20 usage in both ngt and qbg crates. The C++20 requirement is properly configured both in Cargo.toml features and build scripts.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential breaking changes in dependencies # Test: Look for C++ version requirements and breaking changes # Check C++ version requirements in build files rg -l "c\+\+20|cpp20|c\+\+2a" # Look for potential breaking changes in cxx usage ast-grep --pattern 'cxx::bridge! { $_$ }'Length of output: 215
Script:
#!/bin/bash # Check build script configurations and cxx usage patterns cat rust/libs/algorithms/ngt/build.rs cat rust/libs/algorithms/qbg/build.rs # Check for cxx version requirements across crates rg "cxx.*=.*\"1\.0" -A 1 -B 1Length of output: 3451
rust/libs/proto/Cargo.toml (1)
24-28: Verify protobuf compatibility with updated dependencies.The updates to protobuf-related dependencies should be verified for compatibility:
- prost and prost-types versions match (✓)
- tonic and tonic-types versions match (✓)
✅ Verification successful
Dependencies are compatible with proto3 syntax
All proto files in the codebase consistently use proto3 syntax, which is fully supported by the updated dependency versions. The version pairs (prost + prost-types, tonic + tonic-types) are properly matched.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential protobuf compatibility issues # Test: Look for .proto files and their usage # Find all .proto files fd -e proto # Check for protobuf syntax version in .proto files rg -l "syntax\s*=\s*\"proto[23]\""Length of output: 1356
Script:
#!/bin/bash # Check the actual syntax version used in proto files rg "syntax\s*=\s*\"proto[23]\"" -A 1Length of output: 1755
rust/libs/observability/Cargo.toml (1)
24-33: Verify compatibility with the updated OpenTelemetry stack.The significant version jumps in OpenTelemetry dependencies (0.23 → 0.27.1) may introduce breaking changes. Ensure all OpenTelemetry features are working as expected.
✅ Verification successful
OpenTelemetry updates appear safe and beneficial
The version updates (0.27.0/0.27.1) bring stability improvements with APIs moving to Release Candidate status and enhanced troubleshooting capabilities through improved internal logging. The changes are part of a coordinated release across all OpenTelemetry crates.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any compatibility issues or breaking changes in the changelog gh api graphql -f query=' { repository(owner: "open-telemetry", name: "opentelemetry-rust") { releases(first: 5, orderBy: {field: CREATED_AT, direction: DESC}) { nodes { tagName description } } } }'Length of output: 1410
rust/bin/meta/src/main.rs (1)
85-87:⚠️ Potential issueImprove database path configuration and error handling.
The database path is hardcoded and lacks proper error handling.
- let cfg_path = "/tmp/meta/database"; // TODO: set the appropriate path + let cfg_path = std::env::var("META_DB_PATH").unwrap_or_else(|_| { + eprintln!("META_DB_PATH not set, using default path"); + "/tmp/meta/database".to_string() + }); + if !std::path::Path::new(&cfg_path).exists() { + std::fs::create_dir_all(&cfg_path)?; + }Likely invalid or redundant comment.
rust/bin/agent/Cargo.toml (4)
25-25: LGTM! Error handling dependency update.The anyhow update is a patch-level change maintaining backward compatibility.
30-31: LGTM! Verify async runtime dependency compatibility.The tokio ecosystem updates are minor version changes and maintain feature compatibility.
✅ Verification successful
✅ Tokio dependencies are consistent and compatible
All crates use tokio 1.43.0 with full features, maintaining version consistency across the project.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify tokio dependency compatibility across the project fd Cargo.toml | xargs rg "tokio.*= \"1\." -A 1Length of output: 492
32-33: LGTM! Verify gRPC dependency compatibility.The tonic dependency updates maintain version parity and are patch-level changes.
✅ Verification successful
✓ gRPC dependencies are compatible across the project
All tonic-related dependencies are consistently set to version 0.12.3 across the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify gRPC dependency compatibility across the project fd Cargo.toml | xargs rg "tonic.*= \"0\.12\." -A 1Length of output: 416
27-28: LGTM! Verify protobuf dependency compatibility.The prost dependency updates maintain version parity and are compatible with the tonic version.
✅ Verification successful
✅ Protobuf dependencies are consistent and compatible
All prost-related dependencies are aligned at version 0.13.4 across the codebase (meta, agent, and proto library), and they are compatible with tonic 0.12.3.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify protobuf dependency compatibility across the project fd Cargo.toml | xargs rg "prost.*= \"0\.13\." -A 1Length of output: 500
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
example/client/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
example/client/go.mod(1 hunks)example/client/go.mod.default(1 hunks)go.mod(15 hunks)hack/go.mod.default(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- example/client/go.mod.default
- hack/go.mod.default
⏰ Context from checks skipped due to timeout of 90000ms (30)
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
- GitHub Check: build / build
🔇 Additional comments (4)
example/client/go.mod (2)
3-3: Verify Go version compatibility.The Go version has been updated to 1.23.5. However, this version appears to be invalid as the latest stable Go version is 1.22.x.
26-26: Verify version compatibility between vald-client-go and protobuf dependencies.The
vald-client-godependency has been updated to v1.7.16, and the protobuf dependency has been updated to a newer version. Ensure these versions are compatible.Also applies to: 32-32
✅ Verification successful
Dependencies are properly aligned ✅
The vald-client-go v1.7.16 uses the exact same version of protobuf dependencies as your project, ensuring perfect compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any compatibility issues between these versions rg -A 5 "github.com/vdaas/vald-client-go.*1\.7\.16" rg -A 5 "buf\.build/gen/go/bufbuild/protovalidate/protocolbuffers/go.*1\.36\.1"Length of output: 2543
Script:
#!/bin/bash # Check vald-client-go's dependencies curl -sL "https://raw.githubusercontent.com/vdaas/vald-client-go/v1.7.16/go.mod" | grep -A 5 "require" # Check for any compatibility documentation curl -sL "https://raw.githubusercontent.com/vdaas/vald-client-go/v1.7.16/README.md"Length of output: 4176
go.mod (2)
278-288: Verify OpenTelemetry version compatibility.All OpenTelemetry packages have been updated to v1.34.0. Ensure this is a coordinated update and verify compatibility with the rest of the system.
✅ Verification successful
OpenTelemetry version update is properly coordinated
The update to OpenTelemetry v1.34.0 in Go is properly coordinated through replace directives in go.mod, ensuring version consistency across all OpenTelemetry packages. The Rust implementation uses its own independent versioning and is unaffected by this change.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for any compatibility issues or breaking changes rg "opentelemetry" | grep -v "v1.34.0"Length of output: 19839
297-297: Security concern: Potential downgrade of crypto package.The
golang.org/x/cryptopackage appears to be downgraded to v0.32.0. This could have security implications.Also applies to: 523-523
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>
Description
Recreate #2600 and refresh branch.
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Dependencies
kv,opentelemetry,sled, and local observability library.tokio,tonic, andanyhow.Improvements