Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Swap traditional file generator for logrotate_fs for file_to_blackhole test #22285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jszwedko
Copy link
Member

Summary

The current config fails since limits started being applied to the lading container. We think this is a good time to update to the preferred generator anyway.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Will use CI.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

…to_blackhole test

The current config fails since limits started being applied to the lading container. We think this
is a good time to update to the preferred generator anyway.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 22, 2025
@jszwedko jszwedko requested a review from a team as a code owner January 22, 2025 22:38
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/switch-lading-generator-file-to-blackhole
Commit report: e35cc24
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.52s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant