Feature add program gas station #395
Open
+2,362
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldm
reviewed
Jan 24, 2023
evm-utils/evm-bridge/src/main.rs
Outdated
| .ok_or(ParseEvmContractToPayerKeysError::InvalidFormat)?; | ||
| let contract = Address::from_str(addr) | ||
| .map_err(|_| ParseEvmContractToPayerKeysError::InvalidEvmContract)?; | ||
| let payer = Pubkey::from_str(key1) |
There was a problem hiding this comment.
renamed payer to gas_station_payer, removed address/key names
evm-utils/evm-bridge/src/main.rs
Outdated
| #[structopt(long = "gas-station")] | ||
| gas_station_program_id: Option<Pubkey>, | ||
| #[structopt(long = "redirect-to-proxy")] | ||
| redirect_contracts_to_proxy: Option<Vec<EvmContractToPayerKeys>>, |
There was a problem hiding this comment.
Can't we use Vec without option?
| @@ -0,0 +1,53 @@ | |||
| ## Build and deploy | |||
There was a problem hiding this comment.
Can you add example of evm contract, with method.
And write small script that anyone can use to test it out.
| to register payer account that will be paying for incoming evm transactions | ||
| if they meet its filter conditions: | ||
|
|
||
| ``velas evm create-gas-station-payer -u <public rpc> -k <signer keypair> |
There was a problem hiding this comment.
Make owner key optional, by default use signer keypair.
Add command to modify gas station params.
Maybe we should have a way to generate file from abi?
vldm
reviewed
Jan 24, 2023
| ### Start bridge | ||
|
|
||
| Run evm-bridge command with next additional options: | ||
| ``--gas-station <program id> --redirect-to-proxy <evm contract address>:<payer owner pubkey>:<payer storage pubkey>`` |
There was a problem hiding this comment.
Owner is used as a seed for derived address of gas-station payer.
… readme accordingly, add script to deploy test gas-station, create payer and run bridge
gBaGu
force-pushed
the
feature-add-program-gas-station
branch
from
d371712 to
d5cd1fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.