Allow configure Gas Price and Whitelisted Bridges for EVM Subchains #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tirka
force-pushed
the
feature/better-subchain-config
branch
from
89adae7 to
b093796
Compare
vldm
reviewed
Nov 28, 2024
| Default::default(), | ||
| FeatureSet::new_with_all_enabled(), | ||
| ); | ||
| let mut executor = Executor::testing(); |
evm-utils/evm-state/src/executor.rs
Outdated
| @@ -200,39 +200,33 @@ pub struct Executor { | |||
| pub evm_backend: EvmBackend<Incomming>, | |||
| chain_context: ChainContext, | |||
| config: EvmConfig, | |||
|
|
|||
| gas_price: U256, | |||
There was a problem hiding this comment.
move to config (min_gas_price)
| pub feature_set: FeatureSet, | ||
| } | ||
|
|
||
| impl Executor { | ||
| // Return new default executor, with empty state stored in temporary dirrectory | ||
| pub fn testing() -> Self { | ||
| Self::with_config( | ||
| Default::default(), | ||
| Default::default(), |
vldm
reviewed
Nov 30, 2024
vldm
approved these changes
Jan 7, 2025
Tirka
force-pushed
the
feature/better-subchain-config
branch
from
d2de5ff to
8bd491d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP