Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate captureOwnerStack access on experimental.reactOwnerStack #75241

Draft
wants to merge 1 commit into
base: sebbie/react-types-bump
Choose a base branch
from

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 23, 2025

The conditional access was only needed while we have the flag. So we might as well just gate it behind the flag so that we automatically clean it up when we remove the flag.

Since these modules are dev-only we don't need the conditional access here.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 23, 2025
Copy link
Member Author

eps1lon commented Jan 23, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from cd46108 to c1f33f9 Compare January 23, 2025 20:24
@eps1lon eps1lon changed the base branch from canary to sebbie/react-types-bump January 23, 2025 20:25
@eps1lon eps1lon mentioned this pull request Jan 23, 2025
@ijjk
Copy link
Member

ijjk commented Jan 23, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
buildDuration 19.3s 17.5s N/A
buildDurationCached 16.7s 14.1s N/A
nodeModulesSize 419 MB 419 MB N/A
nextStartRea..uration (ms) 445ms 441ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
5306-HASH.js gzip 54.1 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 241 B
main-HASH.js gzip 34.6 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 241 B 241 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
index.html gzip 523 B 523 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 378 kB 378 kB N/A
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 365 kB 365 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.74 MB 1.74 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +3.86 kB
index.pack gzip 75.8 kB 74.4 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +3.86 kB
Diff details
Diff for 5306-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: ec8bd6b

@eps1lon eps1lon force-pushed the sebbie/react-types-bump branch from f581d82 to 78c7f4e Compare January 23, 2025 20:37
@eps1lon eps1lon force-pushed the sebbie/01-23-gate_captureownerstack_access_on_experimental.reactownerstack_ branch from c1f33f9 to ec8bd6b Compare January 23, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants