-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port more to simdeez2 (WIP) #56
Merged
verpeteren
merged 140 commits into
verpeteren:master
from
valadaptive:finish-simdeez2-port
Nov 19, 2024
Merged
Port more to simdeez2 (WIP) #56
verpeteren
merged 140 commits into
verpeteren:master
from
valadaptive:finish-simdeez2-port
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to simdeez overhauled traits
The core library builds now, even if tests don't
The simd_runtime_generate macro adds these for us
I can almost hear the compiler weeping, but this enables proper SIMD codegen.
This was slowing things down a fair bit.
This should recover all lost performance.
@valadaptive Thanks for your work! I made some progress today! only 15 failing tests remaining. Notes:
I pushed my changes to #56 and will probably continue tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #54. The tests have not been updated, and the raw architecture-specific noise functions don't work because of the way simdeez 2 works, but the high-level API works. I've only tested FBM and gradient noise, and fixed some porting bugs along the way; since the original port (#50) used GPT to translate the code to simdeez 2, there are probably more lurking in the parts of the codebase that I didn't test.