Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Query builder #985

Merged
merged 89 commits into from
Jan 10, 2025
Merged

(feat) Query builder #985

merged 89 commits into from
Jan 10, 2025

Conversation

thomasht86
Copy link
Collaborator

@thomasht86 thomasht86 commented Dec 4, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Consider this a first draft, and I can go through it tomorrow.

To discuss:

  • Should we allow for using kwargs for annotations - good for some, but many annotations are camelCase - does not good in python.
  • Rename Q and G- to what?

TODO:

  • Integration test for grouping

@thomasht86
Copy link
Collaborator Author

Discovered more grouping functions that should be added (and tests for) before merging. :D
https://docs.vespa.ai/en/reference/grouping-syntax.html

@thomasht86 thomasht86 marked this pull request as ready for review January 10, 2025 10:01
@thomasht86
Copy link
Collaborator Author

Ready for another review now @glebashnik 🙏

Copy link
Contributor

@glebashnik glebashnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, both design wise and tests.
I setup env and ran tests in Python 2.12 3.12.
For future improvement, it would be great to be able to run tests in different Python versions. Tools like Nox can help with this.

@thomasht86
Copy link
Collaborator Author

thomasht86 commented Jan 10, 2025

Looks very good, both design wise and tests. I setup env and ran tests in Python 2.12. For future improvement, it would be great to be able to run tests in different Python versions. Tools like Nox can help with this.

Thanks. Assume you mean 3.12? 😅 We do run unit tests on matrix of Python 3.8-3.12 and macos, ubuntu, windows.
Doing it for all would take a lot of time and cost a lot, but maybe we could do some of the integration tests at least.

@thomasht86 thomasht86 merged commit a09afbe into master Jan 10, 2025
48 checks passed
@thomasht86 thomasht86 deleted the thomasht86/qbuilder-poc branch January 10, 2025 17:24
@glebashnik
Copy link
Contributor

Right. Found the GH job. All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants