Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Login page and modified password #1023

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

shivenyadavs
Copy link
Contributor

@shivenyadavs shivenyadavs commented Oct 22, 2024


name: Pull_request_TEMPLATE.yml
about: use this template for creation of pull requests
title: '[FIX/Feat] '
labels: ''
assignees: ''


name: Pull Request Template

Description

Key Enhancements:
Performance: Cached passwordField, strengthWeak, strengthMedium, and strengthStrong to avoid repeated DOM lookups.
Dynamic Feedback: Added a displayStrengthMessage function that shows a message (e.g., "Weak password") with corresponding color feedback.
Accessibility: Added aria-label to the password toggle for better screen reader support.
Regex Optimization: Used test() method instead of match() for a more efficient way to check password criteria.
This approach improves the user experience, enhances readability, and makes the code more maintainable.

Screenshots (if applicable)

Screenshot 2024-10-22 201033

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the contributing document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added necessary tests to ensure my changes are effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information


Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 2:41pm

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@github-actions github-actions bot requested a review from vimistify October 22, 2024 14:41
@shivenyadavs
Copy link
Contributor Author

@mansiruhil13 can u please check the changes

@shivenyadavs
Copy link
Contributor Author

@mansiruhil13 can you please merge this

@vimistify vimistify merged commit df607a1 into vimistify:main Oct 30, 2024
2 checks passed
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Develop new page for get started section
2 participants