Add initial sequences package + Make package names consistent #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcp19
reviewed
Dec 11, 2023
jcp19
previously approved these changes
Jan 9, 2024
dnezam
changed the title
seq and set are already reserved, hence we rename them back to their plural counterparts which, according to this [forum exchange](https://forum.golangbridge.org/t/naming-conventions/11180) at least, seems to be the way to go.
jcp19
reviewed
Feb 6, 2024
* Remove unnecessary postcondition * Factor out some quantified postconditions into separate lemmas to have an extrinsic proof of those properties as explained in https://dafny.org/blog/2023/12/01/avoiding-verification-brittleness/
jcp19
reviewed
Feb 7, 2024
|
The following functions still have a quantifier in their postcondition:
Do we want to factor out these quantifiers like we did for IndexOf and IndexOfLast? Additionally, it may be useful to put the 2 quantifiers ensuring that a sequence is the same besides at one index into a separate function, since it is reused multiple times. |
jcp19
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all definitions from Dafny that do not rely on any (multi)set-related definitions. These will be implemented using separate branches.
Additionally renames the packages to their singular form, and updates folder and file names for consistency.