Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sets package #7

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Add sets package #7

merged 14 commits into from
Nov 24, 2023

Conversation

dnezam
Copy link
Collaborator

@dnezam dnezam commented Oct 24, 2023 •
edited
Loading

Roadmap

  • Port over desired definitions from Dafny
  • Port over desired definitions from Verus
  • Port over desired definitions from Why3
  • Discuss whether additional definitions must be added to account for disabling the axiomization in user packages
  • Decide whether to use standard libraries of proof assistants like Coq and Lean
  • Restructure package to make it consistent

@dnezam dnezam marked this pull request as ready for review October 24, 2023 09:37
@dnezam dnezam requested a review from jcp19 November 14, 2023 18:16
jcp19
jcp19 requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for now, I will continue later

sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
jcp19
jcp19 previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after the files are cleaned up and my comments are addressed

sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
sets/sets.gobra Outdated Show resolved Hide resolved
@dnezam dnezam requested a review from jcp19 November 24, 2023 15:47
@jcp19 jcp19 merged commit 7dfa81f into main Nov 24, 2023
1 check passed
@jcp19 jcp19 deleted the sets branch November 24, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcp19 jcp19 Awaiting requested review from jcp19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnezam @jcp19