Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EmptySet with Empty #8

Merged
merged 16 commits into from
Nov 30, 2023
Merged

Replace EmptySet with Empty #8

merged 16 commits into from
Nov 30, 2023

Conversation

dnezam
Copy link
Collaborator

@dnezam dnezam commented Nov 29, 2023

Set in sets.EmptySet() is redundant; additionally, it will be more consistent with the package for sequences (i.e., seqs.Empty())

@dnezam dnezam requested a review from jcp19 November 29, 2023 16:15
Copy link
Collaborator

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcp19 jcp19 merged commit a3bad3e into main Nov 30, 2023
1 check passed
@jcp19 jcp19 deleted the sets branch November 30, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants