-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification of "path" package #9
Open
HSMF
wants to merge
31
commits into
master
Choose a base branch
from
conradin-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this introduces an unverified property of Index
|
Is there any non-trivial dependency between this PR and PR #8? Otherwise, we might want to put in this PR only the changes that have to do with package |
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
|
Below is a table that summarizes the syntactical rewrites that we had to do to verify rewrites (click to expand)Line comments are stripped in this table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we verify the following functions of the
path
package:path.Clean
path.Split
In order to verify this package, we switched out every occurrence of
string
withstring_byte
which is an alias for[]byte
. This is because Gobra does not yet support strings.The main part of the work is on
path.Clean
, which is verified for safety and correctness. We verify thatClean
adheres to the functional specificationSpecClean
Open questions
In
path_spec
, there currently are two unverified functions ("axioms"), both marked as trusted and provided without body:axiomStringByteAcc
: An assumption that it is always fine to restore full permissions to the string. This is not the biggest problem since the original source uses immutable strings anyways but before finalizing this, we should try to get rid of this assumption.axiomEqualGhostEqualPath
: the assumption that for ourPath
struct, ifa == b
thena === b