[packaging] Fixup buildall.bat #1209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made directory creation conditional (if not exist) Removes reference to non-existent file COPYING Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
|
@YanVugenfirer Do we still need this folder for anything? |
YanVugenfirer
approved these changes
Dec 5, 2024
|
@vrozenfe Do we still need this folder for anything? |
|
@YanVugenfirer @vrozenfe @kostyanf14 This basically creates the old unattended floppy disk style OEM TXTSETUP driver disk tree, in this case for If you think it worthwhile, I'm happy to add a commit to delete it here... |
Starting with RHEL-8, we no longer provide VFD images. Also, if we ever do a full cleanup, we could remove all OEM Cheers, |
OK, so let's remove all VFD related stuff @benyamin-codez |
So do you wish me to redo this PR to delete the Will this break anything else in virtio-win, including the packaging repos...? |
Yes
It shouldn't break |
benyamin-codez
added a commit
to benyamin-codez/kvm-guest-drivers-windows
that referenced
this pull request
Dec 18, 2024
1. Remove the packaging folder. Refer to PR virtio-win#1209 for commentary. Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
benyamin-codez
added a commit
to benyamin-codez/kvm-guest-drivers-windows
that referenced
this pull request
Dec 18, 2024
Addendum to 52d23db, 3bc554e and 933b732. 1. Removed packaging folder from root\clean.bat per PR virtio-win#1209. Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
benyamin-codez
added a commit
to benyamin-codez/kvm-guest-drivers-windows
that referenced
this pull request
Dec 18, 2024
Addendum to da96c89 and 74f5391. 1. Removed packaging folder from root\buildAll.bat per PR virtio-win#1209. Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
This was referenced Dec 18, 2024
benyamin-codez
added a commit
to benyamin-codez/kvm-guest-drivers-windows
that referenced
this pull request
Dec 24, 2024
1. Fixed various syntax issues, including an unquoted variable in
conditional test (Debug or Release log file name), superfluous
backslashes, spaces between errorlevel tests and tested functions,
MSBuild syntax consolidaiton, prefixing FOR do commands with @, etc.
2. Unwrapped nested IF statements to ensure no jumping out of loops
or other unexpected behaviours.
3. Updated usage, including Win11 target and explanation regarding
analysis builds (build.bat only).
4. Added analysis build specific variables CODEQL_FAILED and SDV_FAILED
to init area (build.bat only).
5. Refactored fail code, removing return failure detection in favour
of in-line failure detection.
6. Updated labels to use snake style notation.
7. Refactored end of build_arch function to avoide "goto :eof" and
instead use ":build_arch_done" to ensure POPD occurs and
":build_arch_skip" to check for success before ending the local
environment (build.bat only).
8. Do conditional (if exists) removal of sdv and codeql_db folders
(build.bat only).
9. Additional commenting and stdout output (logging).
10. Remove superfluous newline spacing.
11. Removed packaging folder from build per PRs virtio-win#1209 and virtio-win#1224
(buildAll.bat only).
12. Consolidated exiting function (whether success or fail) to
:leave (buildAll.bat only).
Split from PR virtio-win#1212.
.,ueeeeeu,
e$$$$$P?$$$$$b
:$$$$" '$$$$c
$$$$ $$$$c
$$$6 $$$$$
$$$F $$$$"
$$$F $$$F
$$$$ $$$F
$$$$ J$$F .ccCCCCCCCCc,.
?$$$ $$$$$$e ,CCCCCCCCCCCCCCCCCCc
:$$$ `$$$$$" CCCCCCCCCCCCCC" CCCCCC.
`$$$. CCCCCCCCCCC" .,d.`CCCCCC.
$$$t .,uuuuu,. <CCC . `"",$$$$$$L CCCCCC
?$$$ ,HHHHHHHHHHHHHb, CCC $$$$$$$$$P"""" `CCCCC
`$$$ 4F"" .,uuuuuuu,,,,. `CC '=- "$$$="""$$r C><C
`$$$, zuHF""`.,,,,,,. ""??HH `CC bue$:$$$$bd$$$ C ? C
$$$$ -=='.ee???$eeeec,,,.`=. `C $$$$ $$P???$$$ C cC
?$$$ ,H"" .e$P"""?heeee,,."" .'P .cc-=<Cc, cC'CC'
`$$$ HH jF $$$b,/"""cd$$..,,) \ dP". .,cCCCP u
`$$$. .HHH H':F $$$du,$$$$ ' ";l CCCCCCCCCCCCC'.$$
$$$h HHHF H H "$$$$$F d$ 4$$ H ,z "?CCCCCCCCP J$$ :: $
?$$$ HHH'jF.H % $P" ...'" u$ J' .d$$$$F . ....zd$P" :::d$
:$$$ HHH H HF %%,%%" %' dH j$$$$$$$$ ::: ::::: $$
? HF %%%%%.%. " % JHf :: $$$$$$$$$. :::::::::::::::d$$
.::::::::::::: '%%%%%%%%%%/ H" ::::: $$$$$$$$$$ ::::::::::::::d$$$
:::'``````````'::: `%%%%%%%%% JH dH :::::: ?$$$$$$$$$ `:::::::::::: $$$$
..:::::::::::::::. %%%%%%/', H" H","" `::: ?$$$$$$$$$" :::::::::::`$$$$$
... . ::: : . `: `eeeee;".F -.H dHHHHc. $$$$$F"`.=" `:::::::` '?$$$$
::::: .ze$eu . `: =uuuu/"z".H" HHHHHHHHHHe. "" e$$$$$$b :::: ee,. '$$
' z$$$$$$$$$$$$$ `.zeed?"".dHF HHHHHHHHHHHHHH $$$$$beeem ': ec,"$$$$ '
: 4$$$ . $$$$?? beeeeeedHF"".HHHHHF"" _,,.. `$$$$cze= ':,,`"$$$$$$$
: $$$$$b,,d$F , .HHF""".,zeHHHHF" ,i!"` .,;i!!!i;. ?$bee` ::`""9$$$$$$$
: $$$$$$$$$$$L., c,,eeHHHHHHHHF ,i!' .;!!!!!!!!!!!!!!. . ::::""??$$$$$$$
J$$$$$??$,`'". .HHHHHHHHHHHH" ,!!'.i!!!!!!!!!!!!!!!!!! \ ::::: d$bc."??$
"$$$$$$h .; .HHHHHHHHHHHF" ,!!',! !!!!!!''''` '''<!!i ? :::: d$$$$$
:$ "$$$$$$$F uHHHHHHHHHHH" ,!! ,!! !!!" !i ::: $$$$$
$$$ """ "HHHHHHHHH ,!!',!!!! !" .d$$$$ezece$$$, ! ::: d$$$$$'
...: :::::::: 3HHHHH" ,!!',!!!!! d$$$$$$$$$$$$$$$t > ::: d$$$$$
:::: ::` .::::: HHHHF ,!!' !!!!!! 9$$P""""?$$$$$$$$" ! ; `:: $$$$$$ :
::: .::::::::: ?HH" ,!!! !!!!!!! 3$$$.``''$$$F - ; ! ! `: $$$$$$`::
:: .::::::::::: H" ,!!!'<!!!!!!!i $$$$$$$$$$ teeJ' . ! ! : d$$$$$$`::
` .:::::::::::::: " ,!!!! <!!!!!!!! $$$$$$P??'?$$ ! !i ` d$$$$$$L::
::::::::::: `<!!! !!!!!!!!' '$$u,"""" ,' . ; ! `!. d$$$$$$$::
.::::::: aeeee$$$$$$e <!!!!!!!' '.^$$$$$$F' ; !! !!, $$$$$$$$`:
::::::::::`""777d$$$$$$u !!!!!! ' $$ee...e% < , !! `!!i$$$$$$$L :
``````::`` d$$$$$ ?$$$b `!!!' , . $$$$$$$$ . . !! !!!,$$$$$$$ :
eccec,. ,zd$$$$$$$$$$>$L; !' ; , """"""" ; \ `! !!!,?$$$$$ `
$$$$$$$$d$$$$$$$$$P""""` . . ' !!!!!!!!! . `; ` ` !, !!i"$$$$ `
$$$$$$$$$$$$$$$$$F i!!' ,' .. .. ``!!! ! `; \ ` `\`!!.$$$L
>>>"""""""??$$$$k ==" !!' ' , , d$$" u":". !! ! \ `; ` i!i,`!!, ?$F
$$$$UUU$$$$u,"?$$$ =" r ' $F4 ".$$LJ 3$L !!,` ', \ !!i,.`!i.`!.$
$$$$$$$$$$$ec. d$$$ f '" $$F4.$"zP"$$b."b !!,` '! . :!!!!!!i.`!i
"""```"=??he, ?$$$b ,i'! ! d$$$$$d$b$$$$$$F?$ `!='' ..... `!,!i
,,,, ,,, ::: $$$$ `!i 'i" $$$$$$$$$$$$$$$c`" d$$$$$$bc, "?$$$$$$$.!,`!i
$$$' $$$ '::::: '$$$> !!!!! `?$$$$$$$$$$$$F d$$$$$$$$$$F,u.'$$$$$$c!i`!
: .$$$"x ::::: $$$ i!!!!!, $. ``"""""" .,z$$$P"?$$$",ed$$$b $$$$$$i!!!
$e $$$" $R ::::: 3$$ !!!!!!!,`$$bd"uer .dP"""?$$. ?y, "4$$$$$$,`$$$$Fi!!!
" d$$$ :::::::: )$$ !!!!!!i `$$bc . "?bey,. `d$$e `$$$$F $PP"i!!!!
d$$F $r :::::: $$$ )!!!!!! `$$$L".W. "?$by,`"d$$$$$$c $$$" .eeeeu '!
J$$" : .:::: . """ !!!!!!!i. `??$ .,._ `"3$$$$$$$$$b,,,d$$$$$$$$c
"$" ::::::' : !!!!!!!!!!!!i;;i! ueee. `"?$$$$$$$$$$$$$$$$$$$$$$$$$$$F
:.::::::: `:: :: <!!!!!!!!!!!!> z$$$$$$$$$$$be..`'<<<??$$$$$$$$$$$$$$$F.i
:::::::: : :: :: !!!!!!!!!!!':$$$$$$$$$$$$$$$$$$beeeeeee,. ```"`,i!!!
:::::: ::: ::: : !!!!!!!!!' . ""??$$$$$$$$$$$$$$PF"""'` .,,;;ii!!!!!!!!
::::: ::: `:: :: `!!!!!!! !!!!!i,,,,... .....,,,;;;ii!!!!!!!!!!!!!!!!!
::: :: :::: :: :: !!!!!' ,!!!!!!!!!!!!",!!!!!!!!!!!!!!!!!,`!!!!!!!!!!!!!
:` ':: :::: :: :: !!!!' !!!!!!!!!!!!! ,!!!!!!!!!!!!!!!!!!!i!!!!!!!!!!!!!
.:: :: :::: :: :: !!!' !!!!!!!!!!!!'.!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
:::: :: :::: :: :: !!' !!!!!!!!!!!!',!!!!''.,;;;;;,.`'''''''`!!!!!!!!!!!!
:::: :' :::: `: `: !'.!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!i;,,..`'<!!!!!
::: :' ::::: :: :: .!!!! .!!!!!!!i!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!i;;,, '
::`.: .:''` .. . `` . ' , '!!!!i!!!!>:!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
...\..>\\.\\.\\\\ ,/ |, ''```''`<<''<'<<<<<<<!!!!!!!!!!!!!!!!!!!!
`\>/`\\\>\%`%%"./'%..\=///,%//,,/', ,/'' ,/ , `'''''''''''''''''!!!!!!!
//>;>;\.""./';./>.`\- |`/./'','./|'"/`\\</%/'//%','::::::::::::::::!!!!!!'
\.:\'.'///'">>>`,`/'. '. ,` ,/',/',|%//<</,'<^< -=-<'\\'-::``,::'.!!!'` .
/==>'/%.////;.//>>,/,;,.-.`\`,..\`<.\\=\\-^//=/<<\\%'- ' .,::` ..:' '`.:::
'/'/''/'/>.''</>(\<|/%<%///>\`\%</>>\\%\\\>/\'\\\\< `.,'' ..::'`.:.::::'`
/',/"><|,/','/'>,/,/'>/|/>\\`|"\|<``\`\"" \<```.,,'`` ..::::..:::: :::
::::::::::::::::::::::...::::::::::::::::::::''` ...::::::::::::::: :::
............................................. .:::::::::::::::::::: :::
::::::::::::::::::::::::::::::::::::::::::::: :::::::::::::::::::::::: .
Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
YanVugenfirer
pushed a commit
that referenced
this pull request
Jan 5, 2025
benyamin-codez
added a commit
to benyamin-codez/kvm-guest-drivers-windows
that referenced
this pull request
Jan 5, 2025
1. Remove the packaging folder. Refer to PR virtio-win#1209 for commentary. Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
benyamin-codez
added a commit
to benyamin-codez/kvm-guest-drivers-windows
that referenced
this pull request
Jan 18, 2025
1. Fixed various syntax issues, including an unquoted variable in
conditional test (Debug or Release log file name), superfluous
backslashes, spaces between errorlevel tests and tested functions,
MSBuild syntax consolidaiton, prefixing FOR do commands with @, etc.
2. Unwrapped nested IF statements to ensure no jumping out of loops
or other unexpected behaviours.
3. Updated usage, including Win11 target and explanation regarding
analysis builds (build.bat only).
4. Added analysis build specific variables CODEQL_FAILED and SDV_FAILED
to init area (build.bat only).
5. Refactored fail code, removing return failure detection in favour
of in-line failure detection.
6. Updated labels to use snake style notation.
7. Refactored end of build_arch function to avoide "goto :eof" and
instead use ":build_arch_done" to ensure POPD occurs and
":build_arch_skip" to check for success before ending the local
environment (build.bat only).
8. Do conditional (if exists) removal of sdv and codeql_db folders
(build.bat only).
9. Additional commenting and stdout output (logging).
10. Remove superfluous newline spacing.
11. Removed packaging folder from build per PRs virtio-win#1209 and virtio-win#1224
(buildAll.bat only).
12. Consolidated exiting function (whether success or fail) to
:leave (buildAll.bat only).
Split from PR virtio-win#1212.
Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
YanVugenfirer
pushed a commit
that referenced
this pull request
Jan 20, 2025
1. Fixed various syntax issues, including an unquoted variable in
conditional test (Debug or Release log file name), superfluous
backslashes, spaces between errorlevel tests and tested functions,
MSBuild syntax consolidaiton, prefixing FOR do commands with @, etc.
2. Unwrapped nested IF statements to ensure no jumping out of loops
or other unexpected behaviours.
3. Updated usage, including Win11 target and explanation regarding
analysis builds (build.bat only).
4. Added analysis build specific variables CODEQL_FAILED and SDV_FAILED
to init area (build.bat only).
5. Refactored fail code, removing return failure detection in favour
of in-line failure detection.
6. Updated labels to use snake style notation.
7. Refactored end of build_arch function to avoide "goto :eof" and
instead use ":build_arch_done" to ensure POPD occurs and
":build_arch_skip" to check for success before ending the local
environment (build.bat only).
8. Do conditional (if exists) removal of sdv and codeql_db folders
(build.bat only).
9. Additional commenting and stdout output (logging).
10. Remove superfluous newline spacing.
11. Removed packaging folder from build per PRs #1209 and #1224
(buildAll.bat only).
12. Consolidated exiting function (whether success or fail) to
:leave (buildAll.bat only).
Split from PR #1212.
Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made directory creation conditional (if not exist)
Removes reference to non-existent file COPYING