Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors page redesigned #1219

Closed
wants to merge 3 commits into from
Closed

Contributors page redesigned #1219

wants to merge 3 commits into from

Conversation

Son7c
Copy link
Contributor

@Son7c Son7c commented Nov 8, 2024

###feat

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #1197

Description

Changed the entire contributors page.

How Has This Been Tested? ⚙️

I have self review this code many times.

Screenshots 📷

Before
Screenshot 2024-11-08 141913

After

Screen.Recording.2024-11-08.141608.mp4

Type of change

Styling change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for tourmaline-bavarois-d21f10 ready!

Name Link
🔨 Latest commit 3a6d750
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-bavarois-d21f10/deploys/672f800721ecf300082bbd3d
😎 Deploy Preview https://deploy-preview-1219--tourmaline-bavarois-d21f10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Son7c
Copy link
Contributor Author

Son7c commented Nov 9, 2024

@vishanurag @somyadipghosh Please merge this PR as I need the points for the leaderboard. I completed my work as promised.

@vishanurag
Copy link
Owner

Please resolve merge conflicts.

@Son7c
Copy link
Contributor Author

Son7c commented Nov 9, 2024

@vishanurag Resolved

@vishanurag
Copy link
Owner

image

I can't merge this PR because the footer is not looking good now, also the pagination feature of this page is gone...

@vishanurag vishanurag added the wontfix This will not be worked on label Nov 9, 2024
@Son7c
Copy link
Contributor Author

Son7c commented Nov 9, 2024

@vishanurag must be some glitch I'll create a new PR fixing the glitches

@Son7c
Copy link
Contributor Author

Son7c commented Nov 10, 2024

@vishanurag I rechecked my code 10-15 times and its perfectly fine but in deploy its showingdifferent.

@vishanurag
Copy link
Owner

You should create a new pr rather.

@vishanurag vishanurag closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict 😓 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Redesigning the contributors page
2 participants