UoW #1
Open
UoW #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layer into the bussines logic layer getting more granularity. Change the repository into a more generic repository to avoid redundancy.
UoWandGeneric
Pakoke
commented
Jun 8, 2018
| private readonly IPeopleRepository _peopleRepository; | ||
| public PeopleAdderService(IPeopleRepository peopleRepository) | ||
| private readonly IGenericUoW _uow; | ||
| public PeopleAdderService(IGenericUoW uow) |
Pakoke
commented
Jun 9, 2018
|
|
||
| Core.Entities.EF.Person person = null; | ||
| Core.Entities.EF.Store store = null; | ||
| if (customer.PersonId != null) |
There was a problem hiding this comment.
Apply the same behaviour that the data access do. Allow you to control which queries to use.
With a simple view of the logic allow you to realize which object compose a CustomerDTO and allow you in a future to remove or add an unnecessary functionality.
|
|
||
| IEnumerable<TEntity> FindBy(Expression<Func<TEntity, bool>> predicate); | ||
| TEntity GetById(string id); |
There was a problem hiding this comment.
Add common methods instead of add the same method in every particular repository
| @@ -0,0 +1,75 @@ | |||
| using AdventureWorks.Core.Interfaces.Persistance; | |||
There was a problem hiding this comment.
Rename the class Repository.cs to a GenericRepository.cs
added 2 commits
June 10, 2018 12:01
…equest entites to document the swagger api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don´t be afraid!!
I know that I change a lot of things, I just want to discuss all those changes and merge, if you like the changes that you agree.
To sum up, I add you the UoW functionality, GenericRepository and improve the implementation, change the unit test and unify stub repository. Granulate the business logic instead, we replace the same functionality from the data access to the business logic.