Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #149: Added @NgModule declarations… #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

borisfeldmann
Copy link

…to prevent error "NgSemanticModule is not an NgModule"

…or "NgSemanticModule is not an NgModule"
@Tzesar
Copy link

Tzesar commented Mar 12, 2017

Can this be merged?
I need it to build my site in a production environment.

@dinever
Copy link

dinever commented Mar 24, 2017

👍, I'm getting this error too

Failed to compile.
NgSemanticModule is not an NgModule

@AndreasZaschka
Copy link

Hey @Tzesar, @sushanzh
in your package.json use
"ng-semantic": "https://github.com/borisfeldmann/ngSemantic/tarball/master"
and replace the imports of NgSemanticModule from ng-semantic to "ng-semantic/ng-semantic"

@hookedupjoe
Copy link

hookedupjoe commented Apr 21, 2017

Is there a reason this change is not merged? I see it has been approved but still can't use this library in the current CLI environment as is. Thanks for the great library, hope to be able to use it soon in an NPM setting.

Edit: Is there a technical reason we can help resolve to be able to merge this in? :)

@JSMike
Copy link

JSMike commented Apr 29, 2017

@AndreasZaschka that's not relevant, the package.json file wasn't changed in this PR. please pull it in, it's been almost 3 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants