Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vyatta] Bug fixes and improvements #327

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

carlosonunez-vmw
Copy link
Contributor

This pull request fixes the following:

  • Updates the regex for generating networks within vSphere off of the tko-for-vsphere deployment guide
  • Fixes urlencoded slashes in network names for networks created off of vDSes
  • Removes some invalid commands and fixes syntax in some broken commands.

@carlosonunez-vmw carlosonunez-vmw requested review from a team as code owners March 23, 2023 15:20
@vmwclabot
Copy link

@carlosonunez-vmw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

This will make it easier to create the networks that Vyatta needs for
users who wish to use this for creating a Layer 2 network to use Avi
with.

Signed-off-by: Carlos Nunez <ncarlos@vmware.com>
Signed-off-by: Carlos Nunez <ncarlos@vmware.com>
Signed-off-by: Carlos Nunez <ncarlos@vmware.com>
Signed-off-by: Carlos Nunez <ncarlos@vmware.com>
Signed-off-by: Carlos Nunez <ncarlos@vmware.com>
govc vm.network.add -vm="$VM_NAME" -net="${name}-${cidr}-${vlan}" -net.adapter=vmxnet3; \
done < <(grep --color -E 'Network +\|.*_pg +\| [0-9]{4} +\| 172.*' "src/deployment-guides/${DEPLOYMENT_GUIDE}.md")
govc vm.network.add -vm="$VM_NAME" -net="${name}-${vlan}" -net.adapter=vmxnet3; \
done < <(grep -E 'Network {0,}\|.*_pg {0,}\| {0,}[0-9]{3}\..*' "src/deployment-guides/${DEPLOYMENT_GUIDE}.md")
```

Next, go into the vCenter portal and connect to the VM's console. Log in with the username `vyos` and the password `vyos`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Next, go into the vCenter portal and connect to the VM's console. Log in with the username `vyos` and the password `vyos`.
<<Although the following steps have not been modified, wanted to suggest some changes here. Can we change the following steps in a numbered format?>>
-----------------------------------------
1. Go into the vCenter portal and connect to the VM's console.
2. Log in with the username `vyos` and the password `vyos`.
3. Install VyOS onto the machine's disk. Type `install image`, follow the instructions, then shut the machine down. Disconnect its CD-ROM drive, then power it on and log in again.
4. Configure your WAN interface. We'll assume that the externally-accessible network is on subnet `10.213.234.0/24`
5. Run `ifconfig eth0`. Take note of the MAC address for this interface.
6. In vCenter, ensure that the NIC created for this VM with this MAC address is connected to your external network.
We'll assume that your externally-accessible NIC is `eth0`.
Once confirmed, assign this interface with a static IP address in its subnet:

@carlosonunez-vmw
Copy link
Contributor Author

carlosonunez-vmw commented Mar 24, 2023 via email

@reshmarajkumar-vmw reshmarajkumar-vmw added the ix-review-done IX has reviewed the updates label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ix-review-done IX has reviewed the updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants