Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionalities to vip_hci/fm/scattered_light_disk.py #659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmilou
Copy link
Contributor

@jmilou jmilou commented Jan 25, 2025

The pull request adds a new function to scattered_light_disk.py: the possibility to generate a map with the scattering angles in the disk mid plane (useful to see which scattering angles correspond to which part of the disk).
Another change allows the star to be at a position different from the center of the image .

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.96%. Comparing base (4a8e9cf) to head (ad68205).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vip_hci/fm/scattered_light_disk.py 17.65% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   33.13%   28.96%   -4.17%     
==========================================
  Files          87       87              
  Lines       16696    16712      +16     
==========================================
- Hits         5531     4839     -692     
- Misses      11165    11873     +708     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants