Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ssh client and rugged gem #101

Merged
merged 4 commits into from
Aug 2, 2024
Merged

add ssh client and rugged gem #101

merged 4 commits into from
Aug 2, 2024

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Aug 1, 2024

  • rugged uses a native extension, so we need to install the build dependencies

@rwaffen
add ssh client and rugged gem
4360e19 
- rugged uses a native extension, so we need to install the build dependencies

Signed-off-by: Robert Waffen <rwaffen@gmail.com>
@rwaffen rwaffen requested a review from a team as a code owner August 1, 2024 06:06
@rwaffen rwaffen linked an issue Aug 1, 2024 that may be closed by this pull request
Suggestion: Install SSH client for r10k #100
Closed
@rwaffen rwaffen added the enhancement New feature or request label Aug 1, 2024
bastelfreak
bastelfreak reviewed Aug 1, 2024
View reviewed changes
puppetserver/Dockerfile Outdated Show resolved Hide resolved
@rwaffen
add versions for r10k and rugged
8db89e3 
Signed-off-by: Robert Waffen <rwaffen@gmail.com>
@rwaffen rwaffen requested a review from bastelfreak August 2, 2024 08:59
bastelfreak
bastelfreak reviewed Aug 2, 2024
View reviewed changes
puppetserver/Dockerfile Outdated Show resolved Hide resolved
rwaffen added 2 commits August 2, 2024 11:27
@rwaffen
rework installation and remove build-deps afterwards
11a1b9a 
Signed-off-by: Robert Waffen <rwaffen@gmail.com>
@rwaffen
simplify variables. we dont need ENV here, because we dont intend to …
98f9e17 
…use these outside of the Dockerfile

Signed-off-by: Robert Waffen <rwaffen@gmail.com>
marcusdots
marcusdots approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@marcusdots marcusdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is sane. It could be simplified, but that is for another PR.

@marcusdots
Copy link
Contributor

Tested successfully with Puppetfile and ssh

@marcusdots marcusdots merged commit 40c2f35 into main Aug 2, 2024
5 checks passed
@marcusdots marcusdots deleted the 100-suggestion-install-ssh-client-for-r10k branch August 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusdots marcusdots marcusdots approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Crafty Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Install SSH client for r10k
3 participants
@rwaffen @marcusdots @bastelfreak