-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add behavior tests to CI #239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
===========================================
+ Coverage 6.02% 84.13% +78.11%
===========================================
Files 17 30 +13
Lines 846 889 +43
===========================================
+ Hits 51 748 +697
+ Misses 795 141 -654
Continue to review full report at Codecov.
|
af7f652
to
df391f9
Compare
7aab54c
to
6c3c1ae
Compare
I do not understand where |
I'm looking for a way to merge Currently code coverage is enable anywhere (ie. all CI checks run simplecov) and upload to codecov is enabled only with ruby 3.0. |
@smortex |
6c81f51
to
a2cb064
Compare
OK, its working, will improve code after #219 |
@neomilium should we merge this before #219 ? |
@bastelfreak This PR comes after #219 . If needed, it can be reworked to be merged before but IMHO, it easier to merge #219 then rebase this one on top of main branch. |
According to simplecov's documentation¹, to merge multiple results its better to only maintain the `.simplecov` file and let `require 'simplecov'` loads this file. [1] https://github.com/simplecov-ruby/simplecov#using-simplecov-for-centralized-config
To run behavior tests, `aruba` executes `bin/msync` directly. In order to allow simplecov to track files, etc. we need to setup it at application start.
a2cb064
to
68b7578
Compare
Fixes #236