Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior tests to CI #239

Merged
merged 9 commits into from
Oct 8, 2021
Merged

Conversation

neomilium
Copy link
Contributor

@neomilium neomilium commented Oct 6, 2021

Fixes #236

@neomilium neomilium marked this pull request as draft October 6, 2021 15:13
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #239 (e31bed0) into master (98fe295) will increase coverage by 78.11%.
The diff coverage is 50.00%.

❗ Current head e31bed0 differs from pull request most recent head 68b7578. Consider uploading reports for the commit 68b7578 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #239       +/-   ##
===========================================
+ Coverage    6.02%   84.13%   +78.11%     
===========================================
  Files          17       30       +13     
  Lines         846      889       +43     
===========================================
+ Hits           51      748      +697     
+ Misses        795      141      -654     
Impacted Files Coverage Δ
spec/spec_helper.rb 0.00% <0.00%> (ø)
spec/unit/modulesync/git_service_spec.rb 100.00% <100.00%> (ø)
spec/unit/modulesync/git_service/gitlab_spec.rb 100.00% <0.00%> (ø)
spec/helpers/faker.rb 100.00% <0.00%> (ø)
spec/unit/modulesync/git_service/github_spec.rb 0.00% <0.00%> (ø)
features/step_definitions/git_steps.rb 94.87% <0.00%> (ø)
spec/unit/modulesync/settings_spec.rb 100.00% <0.00%> (ø)
spec/unit/modulesync/source_code_spec.rb 100.00% <0.00%> (ø)
spec/helpers/faker/puppet_module_remote_repo.rb 85.71% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fe295...68b7578. Read the comment docs.

@neomilium neomilium force-pushed the ci-improvements branch 2 times, most recently from 7aab54c to 6c3c1ae Compare October 6, 2021 19:38
@neomilium
Copy link
Contributor Author

I do not understand where codecov found 47,36% (-4,99%) as this PR raises code coverage to 93.57% (cf. https://github.com/voxpupuli/modulesync/pull/239/checks?check_run_id=3819493731#step:5:1142)

@smortex
Copy link
Member

smortex commented Oct 6, 2021

The code coverage seems to include the code in the vendor directory, i.e. all dependencies 😒

image

@neomilium
Copy link
Contributor Author

I'm looking for a way to merge cucumber and rspec code coverages before upload to codecov, any help appreciated.

Currently code coverage is enable anywhere (ie. all CI checks run simplecov) and upload to codecov is enabled only with ruby 3.0.

@neomilium
Copy link
Contributor Author

@smortex .simplecov file explicitly exclude '/vendor/' and '/.vendor', any ideas?

@neomilium neomilium force-pushed the ci-improvements branch 4 times, most recently from 6c81f51 to a2cb064 Compare October 6, 2021 22:24
@neomilium
Copy link
Contributor Author

OK, its working, will improve code after #219

@bastelfreak
Copy link
Member

@neomilium should we merge this before #219 ?

@neomilium
Copy link
Contributor Author

@bastelfreak This PR comes after #219 . If needed, it can be reworked to be merged before but IMHO, it easier to merge #219 then rebase this one on top of main branch.

@neomilium neomilium marked this pull request as ready for review October 8, 2021 15:04
@bastelfreak bastelfreak merged commit aa0ab36 into voxpupuli:master Oct 8, 2021
@neomilium neomilium deleted the ci-improvements branch October 8, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior tests are missing in CI
3 participants