-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reference task to generate REFERENCE.md #543
Conversation
I left it out here, but I think we can now modify our Travis release job as follows:
That should fix part of #397 by ensuring we always have an up to date REFERENCE.md on the forge for released modules. |
Btw, puppetlabs/puppet-strings#192 is similar, but doesn't allow overriding the pattern via the config. |
moduleroot/Rakefile.erb
Outdated
|
||
desc 'Generate REFERENCE.md' | ||
task :reference do | ||
Rake::Task['strings:generate'].invoke('<%= @configs['puppet_strings_patterns'] %>', nil, nil, nil, 'false', 'true') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should document what the fields are or link to the documentation as this is hard to grok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I initially attempted to pass in arguments as a named hash but it looks like the rake invoke task doesn't support this so I took this short cut.
Updated. This now requires the freshly released puppet-strings 2.2.0 which includes my patch with a |
voxpupuli/puppet-extlib#131 is how puppet-extlib would make use of this. |
Co-authored-by: Garrett Honeycutt <code@garretthoneycutt.com>
This should be
|
Not sure I follow. Why is that? |
Ahh nevermind that is the custom config for the extlib. |
In puppet-extlib we can now set: