Fix wrong pgbouncer toggle

Unfortunately we inverted the boolean that enables/disables the
pgbouncer.

Currently if `service.disablePgBouncer: false` is set, it will result in
`disableConnectionPooling: true` in the sgcluster. Which in fact
disables the pgbouncer, while it should be enabled in that case.

As both booleans are negative already, they should not be inverted!

pkg/comp-functions/functions/vshnpostgres/postgresql_deploy.go

@@ -417,7 +417,7 @@ func createSgCluster(ctx context.Context, comp *vshnv1.VSHNPostgreSQL, svc *runt
 				Scheduling: &sgv1.SGClusterSpecPodsScheduling{
 					NodeSelector: nodeSelector,
 				},
-				DisableConnectionPooling: ptr.To(false),
+				DisableConnectionPooling: ptr.To(comp.Spec.Parameters.Service.DisablePgBouncer),
 			},
 			NonProductionOptions: &sgv1.SGClusterSpecNonProductionOptions{
 				EnableSetPatroniCpuRequests:    ptr.To(true),
@@ -428,10 +428,6 @@ func createSgCluster(ctx context.Context, comp *vshnv1.VSHNPostgreSQL, svc *runt
 		},
 	}
 
-	if !comp.Spec.Parameters.Service.DisablePgBouncer {
-		sgCluster.Spec.Pods.DisableConnectionPooling = ptr.To(true)
-	}
-
 	TLSSettings := &sgv1.SGClusterSpecPostgresSsl{
 		Enabled: &comp.Spec.Parameters.Service.TLS.Enabled,
 	}

pkg/comp-functions/functions/vshnpostgres/postgresql_deploy_test.go

@@ -66,6 +66,7 @@ func TestPostgreSqlDeploy(t *testing.T) {
 	assert.Equal(t, "sgbackup-"+comp.GetName(), backups[0].SgObjectStorage)
 	assert.Equal(t, comp.Spec.Parameters.Backup.Schedule, *(backups[0].CronSchedule))
 	assert.Equal(t, comp.Spec.Parameters.Backup.Retention, *(backups[0].Retention))
+	assert.Equal(t, comp.Spec.Parameters.Service.DisablePgBouncer, *cluster.Spec.Pods.DisableConnectionPooling)
 
 	sgInstanceProfile := &sgv1.SGInstanceProfile{}
 	assert.NoError(t, svc.GetDesiredKubeObject(sgInstanceProfile, "profile"))