-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PostgreSQL ordering, reduce issues #235
Conversation
@Kidswiss please take a look at this, seems that it was the issue with our services - causing broken deployment of services. After deleting that line everything seems to work. |
Can you elaborate what "probably a bug" you're fixing here? There's more things happening than just deleting a line. |
Was our intention to add this .spec.parameters.security to ObjectBuckets? I'd say no - so it's bug, but I can be wrong and miss some information - therefore "probably a bug" 😆 |
|
0dfb8b3
to
371860a
Compare
9de527a
to
5ee3b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test on lab, so we're sure it doesn't remove any existing sgclusters.
Does this PR help with creating 5 or more instances at the same time? |
yes, it solves the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, again as Simon said, please test with existing buckets, we don't want those buckets to be removed accidentely.
Fix probably a bug in our ObjectStorage spec
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog