Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PostgreSQL ordering, reduce issues #235

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

wejdross
Copy link
Member

Fix probably a bug in our ObjectStorage spec

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@wejdross wejdross added bug Something isn't working minor labels Sep 25, 2024
@wejdross wejdross requested a review from Kidswiss September 25, 2024 16:03
@wejdross
Copy link
Member Author

@Kidswiss please take a look at this, seems that it was the issue with our services - causing broken deployment of services. After deleting that line everything seems to work.

@Kidswiss
Copy link
Contributor

Kidswiss commented Sep 26, 2024

@Kidswiss please take a look at this, seems that it was the issue with our services - causing broken deployment of services. After deleting that line everything seems to work.

Can you elaborate what "probably a bug" you're fixing here? There's more things happening than just deleting a line.

@wejdross
Copy link
Member Author

Was our intention to add this .spec.parameters.security to ObjectBuckets? I'd say no - so it's bug, but I can be wrong and miss some information - therefore "probably a bug" 😆

@Kidswiss
Copy link
Contributor

Was our intention to add this .spec.parameters.security to ObjectBuckets? I'd say no - so it's bug, but I can be wrong and miss some information - therefore "probably a bug" 😆

.spec.parameters.security contains the deletion protection settings for the bucket. They are necessary or they can't delete the buckets anymore, if they use ObjectBucket directly.

@wejdross wejdross changed the title remove security settings Improve PostgreSQL ordering, reduce issues Sep 27, 2024
@wejdross wejdross requested review from a team, TheBigLee and zugao and removed request for a team September 27, 2024 12:28
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test on lab, so we're sure it doesn't remove any existing sgclusters.

@zugao
Copy link
Collaborator

zugao commented Sep 30, 2024

Does this PR help with creating 5 or more instances at the same time?

@wejdross
Copy link
Member Author

Does this PR help with creating 5 or more instances at the same time?

yes, it solves the issue

Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again as Simon said, please test with existing buckets, we don't want those buckets to be removed accidentely.

@wejdross wejdross merged commit 7dd0eb1 into master Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants