Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nextcloud office billing #270

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Enable nextcloud office billing #270

merged 2 commits into from
Dec 3, 2024

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented Nov 22, 2024 •
edited
Loading

Summary

  • Adds nextcloud office billing
  • Adds support for billing service add ons via functional parameters
  • Adds tests

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@zugao zugao added enhancement New feature or request minor labels Nov 22, 2024
@zugao zugao force-pushed the collabora-billing branch from 4b7fb93 to f36efd6 Compare November 22, 2024 13:22
@vshnbot vshnbot mentioned this pull request Nov 22, 2024
Merged
3 tasks
@zugao zugao force-pushed the collabora-billing branch from f36efd6 to c3769c6 Compare November 29, 2024 09:40
@zugao zugao force-pushed the collabora-billing branch from c3769c6 to 1ac1d24 Compare November 29, 2024 09:59
@zugao zugao changed the title Enable collabora billing Enable nextcloud office billing Dec 2, 2024
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team December 2, 2024 10:53
Kidswiss
Kidswiss requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things rest LGTM

apis/vshn/v1/vshn_nextcloud.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/common/billing.go Outdated Show resolved Hide resolved
@zugao zugao force-pushed the collabora-billing branch from 54d029c to 4e346a4 Compare December 3, 2024 09:22
@zugao zugao force-pushed the collabora-billing branch from 4e346a4 to 8c4e9ec Compare December 3, 2024 09:23
@zugao zugao requested a review from Kidswiss December 3, 2024 09:23
@zugao zugao merged commit 237beb2 into master Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zugao @Kidswiss