Set the correct version for the SGCluster #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
TheBigLee
force-pushed
the
fix/scaling_pg_issue
branch
2 times, most recently
from
350ca17 to
ac454f1
Compare
zugao
reviewed
Nov 28, 2024
zugao
reviewed
Nov 28, 2024
Kidswiss
approved these changes
Nov 29, 2024
zugao
approved these changes
Nov 29, 2024
We need to ensure that the SGCluster always contains the "correct" version and that we don't override it with just a major version. The reason is, that Stackgres doesn't allow changing the version number in the `SGCluster` object. Since stackgres changes the version field during a minor upgrade, it won't be possible anymore to "revert" this change to a major version only setting. Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
TheBigLee
force-pushed
the
fix/scaling_pg_issue
branch
from
ac454f1 to
99ff753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to ensure that the SGCluster always contains the "correct" version and that we don't override it with just a major version. The reason is, that Stackgres doesn't allow changing the version number in the
SGClusterobject. Since stackgres changes the version field during a minor upgrade, it won't be possible anymore to "revert" this change to a major version only setting.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog