Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: adding missing tls={} configuration to claim #276

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

wejdross
Copy link
Member

@wejdross wejdross commented Nov 29, 2024

Summary

  • Without this setting some applications might refuse to work with "Server does not support TLS connections"
  • caused by .spec.parameters.service.tls = nil

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@wejdross wejdross changed the title hotfix, tls Hotfix: adding missing tls={} configuration to claim Nov 29, 2024
@wejdross wejdross added bug Something isn't working minor labels Nov 29, 2024
@wejdross wejdross self-assigned this Nov 29, 2024
@wejdross wejdross requested a review from Kidswiss November 29, 2024 13:39
@wejdross wejdross merged commit 1fe7ff4 into master Nov 29, 2024
8 checks passed
@@ -14,6 +14,7 @@ import (
//go:generate yq -i e ../../generated/vshn.appcat.vshn.io_vshnpostgresqls.yaml --expression "with(.spec.versions[]; .schema.openAPIV3Schema.properties.spec.properties.parameters.default={})"
//go:generate yq -i e ../../generated/vshn.appcat.vshn.io_vshnpostgresqls.yaml --expression "with(.spec.versions[]; .schema.openAPIV3Schema.properties.spec.properties.parameters.properties.size.default={})"
//go:generate yq -i e ../../generated/vshn.appcat.vshn.io_vshnpostgresqls.yaml --expression "with(.spec.versions[]; .schema.openAPIV3Schema.properties.spec.properties.parameters.properties.service.default={})"
//go:generate yq -i e ../../generated/vshn.appcat.vshn.io_vshnpostgresqls.yaml --expression "with(.spec.versions[]; .schema.openAPIV3Schema.properties.spec.properties.parameters.properties.service.tls={})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:


//go:generate yq -i e ../../generated/vshn.appcat.vshn.io_vshnpostgresqls.yaml --expression "with(.spec.versions[]; .schema.openAPIV3Schema.properties.spec.properties.parameters.properties.service.tls.default={})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants