Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure correct TLS settings for nested VSHNPostgreSQLs #279

Merged
merged 2 commits into from
Dec 5, 2024
Merged

ensure correct TLS settings for nested VSHNPostgreSQLs #279

merged 2 commits into from
Dec 5, 2024

Conversation

wejdross
Copy link
Member

@wejdross wejdross commented Dec 4, 2024 •
edited
Loading

Summary

  • Propagating TLS settings for nested PostgreSQLs

@wejdross wejdross added bug Something isn't working minor labels Dec 4, 2024
@wejdross wejdross requested review from a team, Kidswiss, TheBigLee and zugao and removed request for a team December 4, 2024 11:55
@vshnbot vshnbot mentioned this pull request Dec 4, 2024
Merged
Kidswiss
Kidswiss approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it on the lab?

@wejdross
Copy link
Member Author

wejdross commented Dec 5, 2024

@Kidswiss yeah, it's still deployed on LAB, so You can check it as well:

ka get xvshnpostgresqls.vshn.appcat.vshn.io -A --no-headers -o yaml | grep -i tls -A 1

We don't want to see any enabled: false

As a test case I created keycloak and nextcloud, afterwards TLS settings in backing PostgreSQL were set correctly

@wejdross wejdross merged commit 44af440 into master Dec 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@zugao zugao Awaiting requested review from zugao zugao was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
bug Something isn't working minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wejdross @Kidswiss