-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for devcontainers #288
Conversation
74d3254
to
c3925d1
Compare
c3925d1
to
031e942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it a lot, it'll grow with time for sure with some customizations and aliases, but I'm ok with that, I think it might make even bigger sense to make dev container with necessary tooling etc. for components, so we have correct jsonnets, commodore etc. that should shorten onboarding drastically
.devcontainer/postCreateCommand.sh
Outdated
printf " | ||
source /usr/share/bash-completion/bash_completion | ||
source $HOME/.kube/completion.bash.inc | ||
alias k=kubectl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small request from my side:
alias ka='kubectl --as cluster-admin'
alias kwp='watch -n 0.1 kubectl get pod'
alias kwo='watch -n 0.1 kubectl get object'
alias kwoa='watch -n 0.1 kubectl --as cluster-admin get object'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alias of ll
is also missing in bash spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add your own aliases via dotfiles. I wouldn't clutter the defaults too much, as everybody wants different things.
Here's an example of my dotfiles: https://git.earthnet.ch/simon.beck/devcontainerdotfiles/src/branch/main/zshrc
the only thing is that rebuilding is enforced and it takes time to achieve, on metered connections it can take ages, maybe we could think of some caching in kindev? |
What do you mean by "rebuilding is enforced"? Once the container is built you can simply start it. |
031e942
to
132f072
Compare
but any interruption, change to dotfiles, oom, whatever will result in rebuilding whole container, this is something I don't like, I can't find any docs, how to shutdown gracefully (keep container in background) and shutdown IDE for exmaple. |
You can As to your other things, yes if it gets interrupted during the execution of the Also, you don't have to rebuild the whole thing if you change your dotfiles. The dotfiles are stored in
And your new things will be applied. Rebuilding is only really required if something fundamentally changes in the |
132f072
to
2e73754
Compare
2e73754
to
61a3558
Compare
Summary
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog