-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for selecting service template #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current state, this PR is not mergeable, as it moves a bunch of Signalilo-specific Service details into this library, which is intended to be a generic client for the Icinga2 API.
Additionally, the PR removes the ability to inspect a service's custom variables as returned from the Icinga2 API completely. This is a clear regression which needs to be addressed, see inline comments for options on how to do this.
I've implemented new helper functions, which flattens the |
Hi, Best Regards |
It's on my TODO list to review this PR and the corresponding Signalilo PR. I'll try to get it done this or next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation LGTM now, except for the inline comment regarding the missing Vars
contents when using GetService()
or ListService()
.
All issues have been fixed |
Implements configurable service template ref: vshn/signalilo#96
See the notes in the PR from vshn/signalilo#116