Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed an assertion in msgpack #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Apr 22, 2020

I ran the tests, and the results were the same before and after this update

@vstakhov
Copy link
Owner

vstakhov commented May 4, 2020

I'm not quite sure that this particular assertion should be removed. Assertions are used to prevent library misusage. A missing parser object is definitely an example of misusage.

Assertions on bad inputs should definitely be removed, on the contrary.

@AdamKorcz
Copy link
Contributor Author

I agree.
We can't, however, fuzz the msgpack functionality, if misusage causes our fuzzers to stop completely in an abort. The rewrite from an abort to the ucl_create_err() will allow our fuzzers to run continuously.
I should note that we most likely need this to be done on all aborts in the msgpack-functionality, so if a few ones are essential then it won't be necessary to rewrite the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants