Do not inheritAttrs on ModalContainer #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great - would fix annoying error |
genu
suggested changes
Jan 27, 2025
Comment on lines
+13
to
+16
| defineOptions({ | ||
| inheritAttrs: false, | ||
| }) | ||
|
|
There was a problem hiding this comment.
This PR should contain only this change alone. The version updates are handled upon release/publish.
An explanation of the issue would helpful. Why does this need to be false?
Comment on lines
-11
to
12
| "vue-final-modal": "workspace:4.5.4", | ||
| "vue-final-modal": "workspace:4.5.5", | ||
| "vue-router": "^4.2.5" |
There was a problem hiding this comment.
We shouldn't have to bump these in this PR. ( See other comment)
There was a problem hiding this comment.
Because we're bumping version, we also get a new lock, which we don't want.
Comment on lines
-19
to
20
| "vue-final-modal": "workspace:4.5.4", | ||
| "vue-final-modal": "workspace:4.5.5", | ||
| "vue3-drag-resize": "^2.0.5" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually I have no idea if it is necessary to have attributes on the ModalContainer. If not this PR should solve: #453