Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update instance and VPC retry on create/delete actions #362

Merged
merged 3 commits into from
May 23, 2023

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented May 17, 2023

Description

  • Add a retry to resource instance create
  • Update the retry on VPC delete to use the correct timeout
  • Adjust some of the VPC variables for better readability

Related Issues

Closes #322

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper requested a review from mondragonfx May 18, 2023 19:16
@optik-aper
Copy link
Member Author

The VPC delete retry will cause a timeout to occur if the VPC is removed when still attached to resources. There's no easy way to determine what is attached to a VPC right now so that we can do the removal in order. That should change with VPC 2.0, so, see issue #363

Copy link
Contributor

@mondragonfx mondragonfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@optik-aper optik-aper merged commit fdceb52 into vultr:master May 23, 2023
@optik-aper optik-aper mentioned this pull request Sep 21, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Floating IP causes error when re-creating the instance to which it is attached
2 participants