Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
buildargs
argument when building an image. This is exposed on theImageBuildOpts
builder asbuild_args()
.Dockerfile
content has been appended with anARG
which is used in tests.Closes: #72
How did you verify your change:
New test:
image_create_with_build_args()
.Also tested within my local app where I need this and it worked just fine.
What (if anything) would need to be called out in the CHANGELOG for the next release:
It's just a minor feature, but maybe good to add that it now works? (was a
TODO
previously).