Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ethernet: T5566: disable energy efficient ethernet (EEE) for interfaces" (backport #3177) #3178

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 24, 2024

Change Summary

This reverts commit ab30509.

As in T6152 there seem to be some NICs that have a non working implementation of reading the EEE registers. Remove this feature in the meantime until there is a less exploding solution hindering boards to boot.

Return to Kernel defaults by removing this code path.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): remove EEE disable functionality

Related Task(s)

Related PR(s)

Component(s) name

Ethernet driver

Proposed changes

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3177 done by [Mergify](https://mergify.com).

…interfaces"

This reverts commit ab30509.

As in T6152 there seem to be some NICs that have a non working implementation
of reading the EEE registers. Remove this feature in the meantime until there
is a less exploding solution hindering boards to boot.

Return to Kernel defaults by removing this code path.

(cherry picked from commit 946f937)
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Mar 24, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team March 24, 2024 08:33
@c-po c-po merged commit 6ad8806 into sagitta Mar 24, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3177 branch March 24, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

2 participants