Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5832: VRRP allow set interface for exluded-address #3200

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Ability to set interface for excluded-address
The excluded-addresses are not listed in the VRRP packet (adverts packets). We have this ability for address, add the same feature for the excluded-address

set high-availability vrrp group GRP-01 excluded-address 192.0.2.202 interface 'dum2'
set high-availability vrrp group GRP-01 excluded-address 192.0.2.203 interface 'dum3'

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

vrrp, keepalived

Proposed changes

How to test

Add excluded-address for an interface:

set high-availability vrrp group GRP-01 address 100.64.0.5
set high-availability vrrp group GRP-01 address 192.0.2.5
set high-availability vrrp group GRP-01 excluded-address 100.64.0.5
set high-availability vrrp group GRP-01 excluded-address 192.0.2.201
set high-availability vrrp group GRP-01 excluded-address 192.0.2.202 interface 'dum2'
set high-availability vrrp group GRP-01 excluded-address 192.0.2.203 interface 'dum3'
set high-availability vrrp group GRP-01 excluded-address 192.0.2.222/24
set high-availability vrrp group GRP-01 interface 'eth1'
set high-availability vrrp group GRP-01 vrid '123'

Check that address is assigned by Keepalived to dummy interface:

vyos@r4# show interfaces dummy 
 dummy dum2 {
 }
 dummy dum3 {
 }
[edit]
vyos@r4# 
[edit]
vyos@r4# run show interfaces dummy 
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
dum2             192.0.2.202/32                    u/u  
dum3             192.0.2.203/32                    u/u  
[edit]
vyos@r4# 

Smoketest result

vyos@r4:~$ 
vyos@r4:~$ /usr/libexec/vyos/tests/smoke/cli/test_high-availability_vrrp.py
test_01_default_values (__main__.TestVRRP.test_01_default_values) ... ok
test_02_simple_options (__main__.TestVRRP.test_02_simple_options) ... ok
test_03_sync_group (__main__.TestVRRP.test_03_sync_group) ... ok
test_04_exclude_vrrp_interface (__main__.TestVRRP.test_04_exclude_vrrp_interface) ... ok
test_05_set_multiple_peer_address (__main__.TestVRRP.test_05_set_multiple_peer_address) ... ok
test_check_health_script (__main__.TestVRRP.test_check_health_script) ... ok

----------------------------------------------------------------------
Ran 6 tests in 70.262s

OK
vyos@r4:~$ 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Ability to set interface for `excluded-address`
The excluded-addresses are not listed in the VRRP packet (adverts packets).
We have this ability for `address`, add the same feature for the
excluded-address

```
set high-availability vrrp group GRP-01 excluded-address 192.0.2.202 interface 'dum2'
set high-availability vrrp group GRP-01 excluded-address 192.0.2.203 interface 'dum3'
```
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team March 28, 2024 12:28
@sever-sever
Copy link
Member Author

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Mar 28, 2024

backport sagitta

✅ Backports have been created

@dmbaturin dmbaturin merged commit 8200126 into vyos:current Mar 28, 2024
8 checks passed
dmbaturin added a commit that referenced this pull request Mar 28, 2024
T5832: VRRP allow set interface for exluded-address (backport #3200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants