Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6192: allow binding SSH to multiple VRF instances #3229

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 1, 2024

Change Summary

Currently VyOS only supports binding a service to one individual VRF. It might become handy to have the services (initially it will be VRF, NTP and SNMP) be bound to multiple VRFs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

SSH

Proposed changes

Changed VRF from leafNode to multi leafNode with defaultValue: default - which is the name of the default VRF.

How to test

Smoketest result

cpo@LR1.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_ssh.py
test_ssh_default (__main__.TestServiceSSH.test_ssh_default) ... ok
test_ssh_dynamic_protection (__main__.TestServiceSSH.test_ssh_dynamic_protection) ... ok
test_ssh_login (__main__.TestServiceSSH.test_ssh_login) ... ok
test_ssh_multiple_listen_addresses (__main__.TestServiceSSH.test_ssh_multiple_listen_addresses) ... ok
test_ssh_ndcpp (__main__.TestServiceSSH.test_ssh_ndcpp) ... ok
test_ssh_single_listen_address (__main__.TestServiceSSH.test_ssh_single_listen_address) ... ok
test_ssh_vrf_multi (__main__.TestServiceSSH.test_ssh_vrf_multi) ... ok
test_ssh_vrf_single (__main__.TestServiceSSH.test_ssh_vrf_single) ... ok

----------------------------------------------------------------------
Ran 8 tests in 47.288s

OK

make test and make testc from a custom ISO build also did report all OK

DEBUG - vyos@vyos:~$ echo EXITCODE:$?
DEBUG - echo EXITCODE:$?
 INFO - Smoketest finished successfully!
 INFO - Powering off system

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team April 1, 2024 18:43
Currently VyOS only supports binding a service to one individual VRF. It might
become handy to have the services (initially it will be VRF, NTP and SNMP) be
bound to multiple VRFs.

Changed VRF from leafNode to multi leafNode with defaultValue: default - which
is the name of the default VRF.
@c-po c-po changed the title T6192: allow binding SSH, NTP and SNMP to multiple VRF instances T6192: allow binding SSH and SNMP to multiple VRF instances Apr 1, 2024
@c-po c-po changed the title T6192: allow binding SSH and SNMP to multiple VRF instances T6192: allow binding SSH to multiple VRF instances Apr 1, 2024
@c-po c-po marked this pull request as ready for review April 1, 2024 20:33
@vyosbot vyosbot requested a review from a team April 1, 2024 20:33
@c-po c-po merged commit 1d34bd8 into vyos:current Apr 2, 2024
9 checks passed
@c-po c-po deleted the multi-vrf branch April 2, 2024 16:32
@c-po
Copy link
Member Author

c-po commented Apr 2, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Apr 2, 2024

backport sagitta

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Apr 3, 2024
T6192: allow binding SSH to multiple VRF instances (backport #3229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant