Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6199: spring cleaning - drop unused Python imports #3240

Merged
merged 4 commits into from
Apr 3, 2024
Merged

T6199: spring cleaning - drop unused Python imports #3240

merged 4 commits into from
Apr 3, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 3, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Smoketest result

image

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 4 commits April 3, 2024 00:00
@c-po
T6199: drop unused sphinx documentation folder
86b6328
@c-po
T6199: replace netifaces.interfaces() with common custom helpers
4c7c168 
* Use interface_exists() outside of verify()
* Use verify_interface_exists() in verify() to drop common error message
@c-po
T6199: drop unused Python imports
274b2da 
found using "git ls-files *.py | xargs pylint | grep W0611"
@c-po
GitHub: add action to check for unused imports
74198e6
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team April 3, 2024 17:01
@c-po c-po closed this Apr 3, 2024
@c-po c-po merged commit d4b53a3 into vyos:current Apr 3, 2024
7 of 8 checks passed
@c-po c-po deleted the spring-cleaning branch April 3, 2024 17:23
@c-po
Copy link
Member Author

c-po commented Apr 3, 2024

@Mergifyio backport sagitta

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited by c-po
Loading

backport sagitta

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@c-po c-po mentioned this pull request Apr 3, 2024
Merged
12 tasks
dmbaturin added a commit that referenced this pull request Apr 4, 2024
@dmbaturin
Merge pull request #3241 from c-po/spring-cleaning-sagitta
7f077a0 
T6199: spring cleaning - drop unused Python imports (backport #3240)
@c-po c-po mentioned this pull request Apr 4, 2024
Merged
12 tasks
@mergify mergify bot mentioned this pull request Apr 4, 2024
Merged
12 tasks
@c-po c-po mentioned this pull request Apr 6, 2024
Merged
12 tasks
@mergify mergify bot mentioned this pull request Apr 6, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @jestabro