Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6203: remove obsoleted xml lib #3255

Merged
merged 2 commits into from
Apr 5, 2024
Merged

T6203: remove obsoleted xml lib #3255

merged 2 commits into from
Apr 5, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Apr 5, 2024

Change Summary

The vyos.xml modules and scripts were replaced with vyos.xml_ref to (1) address a bug with defaults under tag nodes and (2) support extensions (T5218). Remove missed remaining reference in op-mode script otp.py and remove obsoleted code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

git ls-files *.py | xargs pylint | grep E0611 | grep xml

Smoketest result

make test 2>&1|tee out.test
tail -n 12 out.test
DEBUG - echo EXITCODE:$?
 INFO - Smoketest finished successfully!
 INFO - Powering off system
DEBUG - EXITCODE:0poweroff now
 INFO - Shutting down virtual machine
 INFO - Waiting for shutdown...
DEBUG - poweroff now
 INFO - Waiting for shutdown...
DEBUG - poweroff now
 INFO - VM is shut down!
 INFO - Cleaning up
 INFO - Removing disk file: testinstall-20240404-203406-679b.img

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Apr 5, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team April 5, 2024 13:58
@c-po c-po merged commit cc52f47 into vyos:current Apr 5, 2024
9 checks passed
@c-po
Copy link
Member

c-po commented Apr 5, 2024

Would this be a backport candidate @jestabro?

@jestabro
Copy link
Contributor Author

jestabro commented Apr 5, 2024

I think it should be, but I am checking sagitta for any missed occurrences before mergify.

@jestabro
Copy link
Contributor Author

jestabro commented Apr 5, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Apr 5, 2024

backport sagitta

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants