-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6605: restore configd error formatting to be consistent with CLI #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jestabro
requested review from
dmbaturin,
sarthurdev,
zdc,
sever-sever,
c-po and
fett0
July 24, 2024 16:26
👍 |
👍 |
c-po
approved these changes
Jul 24, 2024
CI integration ❌ failed! Details
|
sever-sever
approved these changes
Jul 25, 2024
@Mergifyio backport circinus sagitta |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
) (cherry picked from commit 645f249)
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
) (cherry picked from commit 645f249)
This was referenced Jul 25, 2024
sever-sever
pushed a commit
that referenced
this pull request
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Restore formatting of ConfigError under configd to be consistent with running with no configd support. The formatting was extended in T6559 to report a clearer distinction between configdep script errors and originating script errors, but the change can confuse consistent parsing of errors. Note that this was and remains only a difference in formatting; errors are correctly triggered by configd, both historically and following the fix in T6559.
The only discrepancy in formatting under configd, persistent since its introduction in 1.3, is the lack of the initial path statement, redundant as repeated below the commit error. The example below is the behavior since 1.3, and restored by this PR.
With configd:
Without configd:
Any other desired formatting changes can be provided under this or a separate task. This PR simply restores the previous formatting consistency.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: